Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 118633003: Add more device names to the list of known devices. (Closed)

Created:
6 years, 11 months ago by rpaquay
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add more device names to the list of known devices. BUG=331831 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243606

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/api/music_manager_private/device_id_linux.cc View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 9 (0 generated)
rpaquay
6 years, 11 months ago (2014-01-06 19:20:15 UTC) #1
Marijn Kruisselbrink
lgtm https://codereview.chromium.org/118633003/diff/1/chrome/browser/extensions/api/music_manager_private/device_id_linux.cc File chrome/browser/extensions/api/music_manager_private/device_id_linux.cc (right): https://codereview.chromium.org/118633003/diff/1/chrome/browser/extensions/api/music_manager_private/device_id_linux.cc#newcode19 chrome/browser/extensions/api/music_manager_private/device_id_linux.cc:19: "sda1", "hda1", "dm-0", "xvda1", "sda2", "hda2", "dm-1", "xvda2", ...
6 years, 11 months ago (2014-01-06 19:51:30 UTC) #2
rpaquay
https://codereview.chromium.org/118633003/diff/1/chrome/browser/extensions/api/music_manager_private/device_id_linux.cc File chrome/browser/extensions/api/music_manager_private/device_id_linux.cc (right): https://codereview.chromium.org/118633003/diff/1/chrome/browser/extensions/api/music_manager_private/device_id_linux.cc#newcode19 chrome/browser/extensions/api/music_manager_private/device_id_linux.cc:19: "sda1", "hda1", "dm-0", "xvda1", "sda2", "hda2", "dm-1", "xvda2", On ...
6 years, 11 months ago (2014-01-06 20:47:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/118633003/1
6 years, 11 months ago (2014-01-06 20:48:38 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242085
6 years, 11 months ago (2014-01-07 00:22:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/118633003/1
6 years, 11 months ago (2014-01-07 17:36:12 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242603
6 years, 11 months ago (2014-01-07 20:39:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/118633003/1
6 years, 11 months ago (2014-01-08 17:41:51 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 18:36:48 UTC) #9
Message was sent while issue was closed.
Change committed as 243606

Powered by Google App Engine
This is Rietveld 408576698