Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1186303002: Make ResourceTimingInfo non-refcounted (Closed)

Created:
5 years, 6 months ago by Kunihiko Sakamoto
Modified:
5 years, 6 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, Yoav Weiss, Nate Chapin, gavinp+loader_chromium.org, tyoshino+watch_chromium.org, kinuko
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make ResourceTimingInfo non-refcounted Use OwnPtr to simplify the ownership. This patch also simplifies FetchContext interface a bit, by addig m_isMainResource member to ResourceTimingInfo. BUG=465641 TEST=no functional change; all existing tests should pass Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197313

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M Source/core/fetch/FetchContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FetchContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/loader/FrameFetchContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/timing/ResourceTimingInfo.h View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Kunihiko Sakamoto
Trying to reduce complexity before adding some...
5 years, 6 months ago (2015-06-17 10:22:13 UTC) #3
Nate Chapin
Cool, LGTM
5 years, 6 months ago (2015-06-17 19:22:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186303002/20001
5 years, 6 months ago (2015-06-18 01:24:43 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 03:06:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197313

Powered by Google App Engine
This is Rietveld 408576698