Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 11863012: Add unsupported option to install-build-deps. (Closed)

Created:
7 years, 11 months ago by Torne
Modified:
7 years, 11 months ago
Reviewers:
tony
CC:
chromium-reviews
Visibility:
Public.

Description

Add unsupported option to install-build-deps. Add an option --unsupported to install-build-deps.sh which allows the installation to be attempted on a system we don't support. Omit mentioning this in the error, in the hope that anyone who can deal with the fallout from this will find it in the script. Also, add GCEL (Ubuntu-derived image used by Compute Engine) to the list of supported systems. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176982

Patch Set 1 #

Patch Set 2 : Add GCEL as a supported distro #

Total comments: 1

Patch Set 3 : fix spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M build/install-build-deps.sh View 1 2 2 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Torne
Hi Tony, Is it okay to add this option to make my life easier automating ...
7 years, 11 months ago (2013-01-11 17:07:40 UTC) #1
tony
Can we instead update the regex to allow Ubuntu|GCEL? What is in /etc/issue on Compute ...
7 years, 11 months ago (2013-01-11 18:20:01 UTC) #2
Torne
On 2013/01/11 18:20:01, tony wrote: > Can we instead update the regex to allow Ubuntu|GCEL? ...
7 years, 11 months ago (2013-01-14 16:51:28 UTC) #3
tony
I like updating the regex because it makes people who are testing the script make ...
7 years, 11 months ago (2013-01-14 17:49:06 UTC) #4
Torne
On 2013/01/14 17:49:06, tony wrote: > I like updating the regex because it makes people ...
7 years, 11 months ago (2013-01-14 18:11:26 UTC) #5
tony
On 2013/01/14 18:11:26, Torne wrote: > On 2013/01/14 17:49:06, tony wrote: > > I like ...
7 years, 11 months ago (2013-01-14 18:15:04 UTC) #6
Torne
On 2013/01/14 18:15:04, tony wrote: > On 2013/01/14 18:11:26, Torne wrote: > > On 2013/01/14 ...
7 years, 11 months ago (2013-01-15 21:59:50 UTC) #7
tony
LGTM, thanks! https://codereview.chromium.org/11863012/diff/8001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/11863012/diff/8001/build/install-build-deps.sh#newcode45 build/install-build-deps.sh:45: # the're doing. Nit: the're -> they're
7 years, 11 months ago (2013-01-15 22:01:59 UTC) #8
Torne
7 years, 11 months ago (2013-01-15 22:15:06 UTC) #9
Message was sent while issue was closed.
On 2013/01/15 22:01:59, tony wrote:
> LGTM, thanks!
> 
> https://codereview.chromium.org/11863012/diff/8001/build/install-build-deps.sh
> File build/install-build-deps.sh (right):
> 
>
https://codereview.chromium.org/11863012/diff/8001/build/install-build-deps.s...
> build/install-build-deps.sh:45: # the're doing.
> Nit: the're -> they're

Fixed and landed.

Powered by Google App Engine
This is Rietveld 408576698