Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 11863011: Revert 176340 (Closed)

Created:
7 years, 11 months ago by Joao da Silva
Modified:
7 years, 11 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Revert 176340 > sync: Initialize entries with a valid model type > > This change modifies two important sync functions. > > The first is MutableEntry's CREATE constructor. It now requires that > the ModelType of the entry to be specified when the entry is create. > This doesn't quite eliminate the existence of nodes without a valid > model type (the CREATE_NEW_UPDATE_ITEM can still make them), but it > helps. > > This paves the way for the upcoming UniquePosition change. Part of that > change is that bookmarks must be granted a unique tag on creation. To > support this, we must know at creation time the type of a new entry, so > we can take the appropriate bookmark-specific steps if necessary. > > The second function to get a new signature is WriteNode's > InitByCreation(), which has been renamed to > WriteNode::InitBookmarkByCreation(). The function can only be used to > create bookmarks, so the new name describes its function more precisely. > > Updates to the call-sites of MutableEntry's constructor make up the > majority of this change. This change also includes some minor updates > to test functions that create entries to make them compatible with the > stricter assertions or to make them more closely reflect real world > behaviour. > > BUG=145412, 126505 > > > Review URL: https://chromiumcodereview.appspot.com/11817010 TBR=rlarocque@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -400 lines) Patch
M chrome/browser/sync/glue/bookmark_change_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M sync/engine/apply_updates_and_resolve_conflicts_command_unittest.cc View 5 chunks +16 lines, -13 lines 0 comments Download
M sync/engine/process_commit_response_command_unittest.cc View 11 chunks +105 lines, -78 lines 0 comments Download
M sync/engine/syncer_unittest.cc View 51 chunks +80 lines, -93 lines 0 comments Download
M sync/internal_api/public/test/test_entry_factory.h View 2 chunks +11 lines, -16 lines 0 comments Download
M sync/internal_api/public/write_node.h View 2 chunks +10 lines, -4 lines 0 comments Download
M sync/internal_api/sync_encryption_handler_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 9 chunks +53 lines, -40 lines 0 comments Download
M sync/internal_api/test/test_entry_factory.cc View 7 chunks +19 lines, -47 lines 0 comments Download
M sync/internal_api/write_node.cc View 6 chunks +27 lines, -7 lines 0 comments Download
M sync/syncable/mutable_entry.h View 2 chunks +4 lines, -5 lines 0 comments Download
M sync/syncable/mutable_entry.cc View 3 chunks +12 lines, -23 lines 0 comments Download
M sync/syncable/syncable_unittest.cc View 41 chunks +64 lines, -65 lines 0 comments Download
M sync/test/engine/test_syncable_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Joao da Silva
7 years, 11 months ago (2013-01-11 15:51:22 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698