Implement HasInputDevices in CrasAudioManager

chromeos/audio/audio_device.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/audio/audio_device.h"
 
 #include "base/format_macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 19 matching lines @@
     case AUDIO_TYPE_KEYBOARD_MIC:
     case AUDIO_TYPE_AOKR:
     case AUDIO_TYPE_POST_MIX_LOOPBACK:
     case AUDIO_TYPE_POST_DSP_LOOPBACK:
     case AUDIO_TYPE_OTHER:
     default:
       return 0;
   }
 }
 
+// Check if a node type is for simple record/playback usage.
+// Special usages like keyboard mic, AOKR, loopback are excluded.
+bool IsForSimpleUsage(AudioDeviceType type) {
+  return (type == AUDIO_TYPE_HEADPHONE || type == AUDIO_TYPE_INTERNAL_MIC ||

[jennyz, 2015/06/16 21:51:35]

nit: How about put each type is a separate line, so it looks neater and easier
to list all the types?

[cychiang, 2015/06/23 06:05:40]

Done.

+          type == AUDIO_TYPE_MIC || type == AUDIO_TYPE_USB ||
+          type == AUDIO_TYPE_BLUETOOTH || type == AUDIO_TYPE_HDMI ||
+          type == AUDIO_TYPE_INTERNAL_SPEAKER);
+}
+
 }  // namespace
 
 // static
 std::string AudioDevice::GetTypeString(AudioDeviceType type) {
   switch (type) {
     case AUDIO_TYPE_HEADPHONE:
       return "HEADPHONE";
     case AUDIO_TYPE_MIC:
       return "MIC";
     case AUDIO_TYPE_USB:
@@ skipping 44 matching lines @@
   else if (node_type.find("POST_MIX_LOOPBACK") != std::string::npos)
     return AUDIO_TYPE_POST_MIX_LOOPBACK;
   else if (node_type.find("POST_DSP_LOOPBACK") != std::string::npos)
     return AUDIO_TYPE_POST_DSP_LOOPBACK;
   else
     return AUDIO_TYPE_OTHER;
 }
 
 AudioDevice::AudioDevice()
     : is_input(false),
+      is_for_simple_usage(true),
       id(0),
       display_name(""),
       type(AUDIO_TYPE_OTHER),

[jennyz, 2015/06/16 21:51:35]

This seems conflicting with IsForSimpleUsage(), the default type
AUDIO_TYPE_OTHER is not listed as a simple usage type, while is_for_simple_usage
is default to true here?

[cychiang, 2015/06/23 06:05:40]

Done.

       priority(0),
       active(false),
       plugged_time(0) {
 }
 
 AudioDevice::AudioDevice(const AudioNode& node) {
   is_input = node.is_input;
   id = node.id;
   type = GetAudioType(node.type);
+  is_for_simple_usage = IsForSimpleUsage(type);

[Daniel Erat, 2015/06/18 14:53:20]

this member is just derived from another member, type. it'd be better to make it
be a simple inlined public is_for_simple_usage() method. that eliminates the
risk of the two getting out of sync.

[cychiang, 2015/06/23 06:05:40]

Done.

   if (!node.name.empty() && node.name != "(default)")
     display_name = node.name;
   else
     display_name = node.device_name;
   device_name = node.device_name;
   priority = GetDevicePriority(type);
   active = node.active;
   plugged_time = node.plugged_time;
 }
 
@@ skipping 18 matching lines @@
                       "active = %s ",
                       active ? "true" : "false");
   base::StringAppendF(&result,
                       "plugged_time= %s ",
                       base::Uint64ToString(plugged_time).c_str());
 
   return result;
 }
 
 }  // namespace chromeos