Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1186273005: Block pretty printing (partial re-revert of 1177123002). (Closed)

Created:
5 years, 6 months ago by Mircea Trofin
Modified:
5 years, 6 months ago
CC:
v8-dev, Jarin, Benedikt Meurer, jvoung (off chromium), Jim Stichnoth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Block pretty printing (partial re-revert of 1177123002). Revert "Revert of Decompiler improvements. (patchset #2 id:20001 of https://codereview.chromium.org/1177123002/)" This reverts commit e2ce4681655a610631e6a6e17dec62e6c4bdef43, avoiding the hex->dec changes, and re-introducing the block pretty printing of the original CL. The hex-dec issue would be handled separately. BUG= Committed: https://crrev.com/9b62bb32fb8986c271f177d86cf234b92bca46dd Cr-Commit-Position: refs/heads/master@{#29063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +23 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mircea Trofin
5 years, 6 months ago (2015-06-17 00:12:20 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-17 04:56:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186273005/1
5 years, 6 months ago (2015-06-17 05:00:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 05:44:28 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 05:44:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b62bb32fb8986c271f177d86cf234b92bca46dd
Cr-Commit-Position: refs/heads/master@{#29063}

Powered by Google App Engine
This is Rietveld 408576698