Refactor OS X sandbox processing and audit sandbox files

content/common/sandbox_mac_compiler_unittest.mm

Index: content/common/sandbox_mac_compiler_unittest.mm
diff --git a/content/common/sandbox_mac_compiler_unittest.mm b/content/common/sandbox_mac_compiler_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..2062ecfe7117bed19b4d63a985abccbd81f3c350
--- /dev/null
+++ b/content/common/sandbox_mac_compiler_unittest.mm
@@ -0,0 +1,164 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/common/sandbox_mac.h"
+
+#include <fcntl.h>
+#include <unistd.h>
+#include <sys/stat.h>
+
+#include "base/process/kill.h"
+#include "base/test/multiprocess_test.h"
+#include "base/test/test_timeouts.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "testing/multiprocess_func_list.h"
+
+namespace content {
+
+class SandboxMacCompilerTest : public base::MultiProcessTest {};
+
+MULTIPROCESS_TEST_MAIN(BasicProfileProcess) {
+  std::string profile =
+      "(version 1)"
+      "(allow file-read* file-write* (literal \"/\"))";
+
+  SandboxCompiler compiler(profile);
+  CHECK_EQ(compiler.Init(), true);

[Robert Sesek, 2015/06/16 23:52:41]

CHECK_EQ(…, bool) can be jut CHECK(…)

[Greg K, 2015/06/18 20:45:18]

Done: since Init() went away this did too.

+
+  std::string error;
+  CHECK_EQ(compiler.CompileAndApplyProfile(&error), 0);
+
+  return 0;
+}
+
+TEST_F(SandboxMacCompilerTest, BasicProfileTest) {
+  base::Process process = SpawnChild("BasicProfileProcess");
+  ASSERT_TRUE(process.IsValid());
+  int exit_code = 42;
+  EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
+                                             &exit_code));
+  EXPECT_EQ(exit_code, 0);
+}
+
+MULTIPROCESS_TEST_MAIN(BasicProfileWithParamProcess) {
+  std::string profile =
+      "(version 1)"
+      "(allow file-read* file-write* (literal (param \"DIR\")))";
+
+  SandboxCompiler compiler(profile);
+  CHECK_EQ(compiler.Init(), true);
+  compiler.InsertStringParam("DIR", "/");
+
+  std::string error;
+  EXPECT_EQ(compiler.CompileAndApplyProfile(&error), 0);
+
+  return 0;
+}
+
+TEST_F(SandboxMacCompilerTest, BasicProfileTestWithParam) {
+  base::Process process = SpawnChild("BasicProfileWithParamProcess");
+  ASSERT_TRUE(process.IsValid());
+  int exit_code = 42;
+  EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
+                                             &exit_code));
+  EXPECT_EQ(exit_code, 0);
+}
+
+MULTIPROCESS_TEST_MAIN(ProfileFunctionalProcess) {
+  std::string profile =
+      "(version 1)"
+      "(debug deny)"
+      "(allow file-read-data file-read-metadata (literal \"/dev/urandom\"))";
+
+  SandboxCompiler compiler(profile);
+  CHECK_EQ(compiler.Init(), true);
+
+  std::string error;
+  EXPECT_EQ(compiler.CompileAndApplyProfile(&error), 0);
+
+  // The profile compiled and applied successfully, now try and read 1 byte from
+  // /dev/urandom
+  uint8_t byte;
+  int fd = open("/dev/urandom", O_RDONLY);
+  CHECK_NE(fd, -1);
+
+  EXPECT_TRUE(read(fd, &byte, sizeof(byte)) == sizeof(byte));
+
+  return 0;
+}
+
+TEST_F(SandboxMacCompilerTest, ProfileFunctionalityTest) {
+  base::Process process = SpawnChild("ProfileFunctionalProcess");
+  ASSERT_TRUE(process.IsValid());
+  int exit_code = 42;
+  EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
+                                             &exit_code));
+  EXPECT_EQ(exit_code, 0);
+}
+
+MULTIPROCESS_TEST_MAIN(ProfileFunctionalTestWithParamsProcess) {
+  std::string profile =
+      "(version 1)"
+      "(debug deny)"
+      "(if (string=? (param \"ALLOW_FILE\") \"TRUE\")"
+      "    (allow file-read-data file-read-metadata (literal (param "
+      "\"URANDOM\"))))";
+
+  SandboxCompiler compiler(profile);
+  CHECK_EQ(compiler.Init(), true);
+
+  compiler.InsertBooleanParam("ALLOW_FILE", true);
+  compiler.InsertStringParam("URANDOM", "/dev/urandom");
+
+  std::string error;
+  EXPECT_EQ(compiler.CompileAndApplyProfile(&error), 0);
+
+  // The profile compiled and applied successfully, now try and read 1 byte from
+  // /dev/urandom
+  uint8_t byte;
+  int fd = open("/dev/urandom", O_RDONLY);
+  CHECK_NE(fd, -1);
+
+  EXPECT_TRUE(read(fd, &byte, sizeof(byte)) == sizeof(byte));
+
+  // Make sure the sandbox isn't overly permissive
+  struct stat st;
+  EXPECT_EQ(stat("/", &st), -1);
+
+  return 0;
+}
+
+TEST_F(SandboxMacCompilerTest, ProfileFunctionalityTestWithParams) {
+  base::Process process = SpawnChild("ProfileFunctionalTestWithParamsProcess");
+  ASSERT_TRUE(process.IsValid());
+  int exit_code = 42;
+  EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
+                                             &exit_code));
+  EXPECT_EQ(exit_code, 0);
+}
+
+MULTIPROCESS_TEST_MAIN(ProfileFunctionalityTestErrorProcess) {
+  std::string profile = "(+ 5 a)";
+
+  SandboxCompiler compiler(profile);
+  CHECK_EQ(compiler.Init(), true);
+
+  // Make sure that this invalid profile results in an error returned
+  std::string error;
+  CHECK_EQ(error, "");
+  CHECK_NE(compiler.CompileAndApplyProfile(&error), 0);
+  CHECK_NE(error, "");
+
+  return 0;
+}
+
+TEST_F(SandboxMacCompilerTest, ProfileFunctionalityTestError) {
+  base::Process process = SpawnChild("ProfileFunctionalityTestErrorProcess");
+  ASSERT_TRUE(process.IsValid());
+  int exit_code = 42;
+  EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
+                                             &exit_code));
+  EXPECT_EQ(exit_code, 0);
+}
+}

[Robert Sesek, 2015/06/16 23:52:41]

nit: Blank line before, and closing namespaces (except for forward-declarations)
always end in "  // namespace <namespace>" (note two spaces before EOL
comments).

[Greg K, 2015/06/18 20:45:18]

Done.