content/ppapi_plugin/ppapi.sb - Issue 1186233004: Refactor OS X sandbox processing and audit sandbox files

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/ppapi_plugin/ppapi.sb

Issue 1186233004: Refactor OS X sandbox processing and audit sandbox files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per code review Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/common/sandbox_mac_compiler_unittest.mm ('K') | « content/content_tests.gypi ('k') | content/renderer/renderer.sb » ('j') | no next file with comments »

OLD	NEW
1 ;;	1 ;;

2 ;; Copyright (c) 2012 The Chromium Authors. All rights reserved.	2 ;; Copyright (c) 2012 The Chromium Authors. All rights reserved.

3 ;; Use of this source code is governed by a BSD-style license that can be	3 ;; Use of this source code is governed by a BSD-style license that can be

4 ;; found in the LICENSE file.	4 ;; found in the LICENSE file.

5 ;;	5 ;;

6	6

7 ; TODO(viettrungluu): Confirm that the exceptions below are needed.	7 ; TODO(viettrungluu): Confirm that the exceptions below are needed.

8	8

9 ; * The contents of content/common/common.sb are implicitly included here. *	9 ; * The contents of content/common/common.sb are implicitly included here. *

10	10

11 ; Needed for Fonts.	11 ; Needed for Fonts.

12 (allow file-read* (regex #"^/System/Library/Fonts($\|/)")) ; 10.5.6	12 (allow file-read* (regex #"^/System/Library/Fonts($\|/)"))

13 ; 10.6 for loading fonts in the renderer.

14 ; on 10.5 this is needed for the PDF plugin.

15 (allow file-read* (regex #"^/Library/Fonts($\|/)"))	13 (allow file-read* (regex #"^/Library/Fonts($\|/)"))

16 (allow mach-lookup (global-name "com.apple.FontObjectsServer")) ; 10.5.6	14 (allow mach-lookup (global-name "com.apple.FontObjectsServer"))

17 (allow mach-lookup (global-name "com.apple.FontServer")) ; 10.6	15 (allow mach-lookup (global-name "com.apple.FontServer"))

18	16

19 ; http://crbug.com/11269	17 ; http://crbug.com/11269

20 (allow file-read* (subpath "@USER_HOMEDIR_AS_LITERAL@/Library/Fonts")) ; 10.6	18 (allow file-read* (subpath (string-append (param homedir-as-literal) "/Library/F onts")))
	Robert Sesek 2015/06/22 20:40:23 Make a function user-homedir-path, since you do th Make a function user-homedir-path, since you do this in renderer.sb too? Greg K 2015/06/23 19:05:15 Done. Show quoted text On 2015/06/22 20:40:23, Robert Sesek wrote: > Make a function user-homedir-path, since you do this in renderer.sb too? Done.
OLD	NEW