Fix WebDataRequest ownership gap

chrome/browser/webdata/web_data_request_manager.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Chromium settings and storage represent user-selected preferences and
 // information and MUST not be extracted, overwritten or modified except
 // through Chromium defined APIs.
 
 #ifndef CHROME_BROWSER_WEBDATA_WEB_DATA_REQUEST_MANAGER_H__
 #define CHROME_BROWSER_WEBDATA_WEB_DATA_REQUEST_MANAGER_H__
@@ skipping 13 matching lines @@
 
 //////////////////////////////////////////////////////////////////////////////
 //
 // Webdata requests
 //
 // Every request is processed using a request object. The object contains
 // both the request parameters and the results.
 //////////////////////////////////////////////////////////////////////////////
 class WebDataRequest {
  public:
-  WebDataRequest(WebDataService* service,
-                 WebDataServiceConsumer* consumer,
+  WebDataRequest(WebDataServiceConsumer* consumer,
                  WebDataRequestManager* manager);
 
   virtual ~WebDataRequest();
 
   WebDataServiceBase::Handle GetHandle() const;
 
   // Retrieves the |consumer_| set in the constructor.
   WebDataServiceConsumer* GetConsumer() const;
 
+  // Retrieves the original message loop the of the request.
+  MessageLoop* GetMessageLoop() const;
+
   // Returns |true| if the request was cancelled via the |Cancel()| method.
   bool IsCancelled() const;
 
   // This can be invoked from any thread. From this point we assume that
   // our consumer_ reference is invalid.
   void Cancel();
 
-  // Invoked by the service when this request has been completed.
-  // This will notify the service in whatever thread was used to create this
-  // request.
-  void RequestComplete();
+  // Invoked when the request has been completed.
+  void OnComplete();
 
   // The result is owned by the request.
   void SetResult(scoped_ptr<WDTypedResult> r);
-  const WDTypedResult* GetResult() const;
+  scoped_ptr<WDTypedResult> GetResult();

[erikwright (departed), 2013/01/28 20:01:05]

A note that the caller should only invoke this one time.

[Cait (Slow), 2013/01/29 01:10:29]

Done.

 
  private:
-  // Used to notify service of request completion.
-  scoped_refptr<WebDataService> service_;
+  // Used to notify manager if request is cancelled.

[erikwright (departed), 2013/01/28 20:01:05]

A note about why a raw pointer is used vs. a ref_ptr

[Cait (Slow), 2013/01/29 01:10:29]

Done.

+  WebDataRequestManager* manager_;
 
   // Tracks loop that the request originated on.
   MessageLoop* message_loop_;
 
   // Identifier for this request.
   WebDataServiceBase::Handle handle_;
 
   // A lock to protect against simultaneous cancellations of the request.
   // Cancellation affects both the |cancelled_| flag and |consumer_|.
   mutable base::Lock cancel_lock_;
   bool cancelled_;
 
   // The originator of the service request.
   WebDataServiceConsumer* consumer_;
 
   scoped_ptr<WDTypedResult> result_;
 
   DISALLOW_COPY_AND_ASSIGN(WebDataRequest);
 };
 
 //////////////////////////////////////////////////////////////////////////////
 //
 // Webdata Request Manager
 //
 // Tracks all WebDataRequests for a WebDataService.
 //
 // Note: This is an internal interface, not to be used outside of webdata/
 //////////////////////////////////////////////////////////////////////////////
-class WebDataRequestManager {
+class WebDataRequestManager : public base::RefCounted<WebDataRequestManager> {
  public:
   WebDataRequestManager();
 
-  ~WebDataRequestManager();
-
   // Cancel any pending request.
   void CancelRequest(WebDataServiceBase::Handle h);
 
-  // Invoked by request implementations when a request has been processed.
-  void RequestCompleted(WebDataServiceBase::Handle h);
+  // Invoked by the WebDataService when |request| has been completed.
+  void RequestCompleted(scoped_ptr<WebDataRequest> request);
+
+  // This will notify the consumer in whatever thread was used to create this
+  // request.
+  void RequestCompletedOnThread(scoped_ptr<WebDataRequest> request);

[erikwright (departed), 2013/01/28 20:01:05]

needs to be public?

[Cait (Slow), 2013/01/29 01:10:29]

Done.

 
   // Register the request as a pending request.
   void RegisterRequest(WebDataRequest* request);
 
   // Return the next request handle.
   int GetNextRequestHandle();
 
  private:
+  friend class base::RefCounted<WebDataRequestManager>;
+
+  ~WebDataRequestManager();
+
   // A lock to protect pending requests and next request handle.
   base::Lock pending_lock_;
 
   // Next handle to be used for requests. Incremented for each use.
   WebDataServiceBase::Handle next_request_handle_;
 
   typedef std::map<WebDataServiceBase::Handle, WebDataRequest*> RequestMap;
   RequestMap pending_requests_;
 
   DISALLOW_COPY_AND_ASSIGN(WebDataRequestManager);
 };
 
 #endif  // CHROME_BROWSER_WEBDATA_WEB_DATA_REQUEST_MANAGER_H__