Issue 1186173004: Revert of Serializer: clear string hash for code serializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1186173004: Revert of Serializer: clear string hash for code serializer. (Closed)

Created:
5 years, 6 months ago by Yang

Modified:
5 years, 6 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev, Yang

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Serializer: clear string hash for code serializer. (patchset #1 id:1 of https://codereview.chromium.org/1183483006/) Reason for revert: This led to the roll being stuck: https://codereview.chromium.org/1189863003/ Original issue's description: > Serializer: clear string hash for code serializer. > > R=jochen@chromium.org > BUG=v8:4179 > LOG=N > > Committed: https://crrev.com/a0342678e865337215f9195f983c6013b60e7641 > Cr-Commit-Position: refs/heads/master@{#29016} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4179 Committed: https://crrev.com/22160e7c3945ef5290266dbb628fb8daba5436fd Cr-Commit-Position: refs/heads/master@{#29065}

Created: 5 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -23 lines)			Patch
	M	src/snapshot/serialize.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/snapshot/serialize.cc	View		2 chunks	+14 lines, -22 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

Created Revert of Serializer: clear string hash for code serializer.

5 years, 6 months ago (2015-06-17 06:45:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186173004/1

5 years, 6 months ago (2015-06-17 06:45:17 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-17 06:45:38 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/22160e7c3945ef5290266dbb628fb8daba5436fd
Cr-Commit-Position: refs/heads/master@{#29065}