git_cl.py: In the "status" command, add space after the branch name.

git_cl.py: In the "status" command, add space after the branch name.

i.e. the output looks like:

   my-branch-name : https://codereview.chromium.org/1234567
  my-other-branch : https://codereview.chromium.org/8675309

This makes it possible to double-click the branch name to use it in a subsequent
command.

BUG=none
R=maruel@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=241731

[M-A Ruel, 2013-12-18 23:11:21]

lgtm

[commit-bot: I haz the power, 2013-12-18 23:11:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/118613003/1

[commit-bot: I haz the power, 2013-12-18 23:13:06]

Presubmit check for 118613003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
push-basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1906 --:--:-- --:--:-- --:--:--  1974
TESTING: Base URL contains branch name
TESTING: git-cl push ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description:
foo-quux

Review URL: http://localhost:8080/5629499534213120
Closing issue (you may be prompted for your codereview password)...
TESTING: committed code has proper description
TESTING: issue no longer has a branch
FAILURE: issue no longer has a branch


basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1717 --:--:-- --:--:-- --:--:--  1750
TESTING: git-cl dcommits ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description:
foo-quux

Review URL: http://localhost:8080/5840605766746112
Closing issue (you may be prompted for your codereview password)...
TESTING: dcommitted code has proper description
TESTING: issue no longer has a branch
FAILURE: issue no longer has a branch


Presubmit checks took 91.9s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2013-12-18 23:20:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/118613003/1

[commit-bot: I haz the power, 2013-12-18 23:22:05]

Presubmit check for 118613003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
push-basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1874 --:--:-- --:--:-- --:--:--  1925
TESTING: Base URL contains branch name
TESTING: git-cl push ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description:
foo-quux

Review URL: http://localhost:8080/5629499534213120
Closing issue (you may be prompted for your codereview password)...
TESTING: committed code has proper description
TESTING: issue no longer has a branch
FAILURE: issue no longer has a branch


basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1710 --:--:-- --:--:-- --:--:--  1750
TESTING: git-cl dcommits ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description:
foo-quux

Review URL: http://localhost:8080/5840605766746112
Closing issue (you may be prompted for your codereview password)...
TESTING: dcommitted code has proper description
TESTING: issue no longer has a branch
FAILURE: issue no longer has a branch


Presubmit checks took 110.6s to calculate.

[binji, 2013-12-18 23:42:44]

Is this because my base URL is not SVN...?

[M-A Ruel, 2013-12-18 23:45:01]

On 2013/12/18 23:42:44, binji wrote:
> Is this because my base URL is not SVN...?

No, I think the regression is genuine. Can you look at tests/basic.sh?

[binji, 2013-12-19 00:05:21]

On 2013/12/18 23:45:01, M-A Ruel wrote:
> On 2013/12/18 23:42:44, binji wrote:
> > Is this because my base URL is not SVN...?
> 
> No, I think the regression is genuine. Can you look at tests/basic.sh?

Ah, I see the failure. I was misunderstanding the presubmit output.

Got a bit further when testing locally, but now it's complaining that I'm not
running a rietveld server on localhost.

I ran "git cl presubmit" which says it should set up everything for me. :-)

** Presubmit ERRORS **
push-basic.sh failed
Command /usr/local/google/home/binji/dev/depot_tools/tests/push-basic.sh
returned non-zero exit status 1 in
/usr/local/google/home/binji/dev/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
fatal: Needed a single revision
Command "git rev-parse --verify master" failed.

FAILURE: upload succeeds (needs a server running on localhost)

[commit-bot: I haz the power, 2013-12-19 00:52:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/118613003/20001

[commit-bot: I haz the power, 2013-12-19 00:55:32]

Change committed as 241731