Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

Issue 1186113006: DevToo: fix JavaScriptBreakpoint checkboxes in Sources panel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
diff --git a/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js b/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
index 450e0448d4eff84d6fb4602f85d30a96e7275793..1a4aabeeb5a6cd6f9f376986cc78cb07c45c2ecf 100644
--- a/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
+++ b/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
@@ -75,9 +75,9 @@ WebInspector.JavaScriptBreakpointsSidebarPane.prototype = {
element.addEventListener("contextmenu", this._breakpointContextMenu.bind(this, breakpoint), true);
element.addEventListener("click", this._breakpointClicked.bind(this, uiLocation), false);
- var checkbox = createCheckboxLabel(uiLocation.linkText(), breakpoint.enabled());
- element.appendChild(checkbox);
- checkbox.addEventListener("click", this._breakpointCheckboxClicked.bind(this, breakpoint), false);
+ var checkboxLabel = createCheckboxLabel(uiLocation.linkText(), breakpoint.enabled());
+ element.appendChild(checkboxLabel);
+ checkboxLabel.addEventListener("click", this._breakpointCheckboxClicked.bind(this, breakpoint), false);
var snippetElement = element.createChild("div", "source-text monospace");
@@ -108,7 +108,7 @@ WebInspector.JavaScriptBreakpointsSidebarPane.prototype = {
}
this._addListElement(element, currentElement);
- var breakpointItem = { element: element, checkbox: checkbox };
+ var breakpointItem = { element: element, checkbox: checkboxLabel.checkboxElement };
this._items.set(breakpoint, breakpointItem);
this.expand();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698