Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 1186113006: DevToo: fix JavaScriptBreakpoint checkboxes in Sources panel (Closed)

Created:
4 years, 10 months ago by lushnikov
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevToo: fix JavaScriptBreakpoint checkboxes in Sources panel Due to refactoring in r196782, a checkbox object does not refer a checkbox. BUG=501676 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
lushnikov
ptal
4 years, 10 months ago (2015-06-18 10:41:10 UTC) #1
pfeldman
lgtm
4 years, 10 months ago (2015-06-18 10:57:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186113006/1
4 years, 10 months ago (2015-06-18 10:58:08 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 12:19:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197347

Powered by Google App Engine
This is Rietveld 408576698