Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 1186103003: Move workers' Performance API code to core/timing (Closed)

Created:
4 years, 10 months ago by Kunihiko Sakamoto
Modified:
4 years, 10 months ago
Reviewers:
kinuko, Mike West
CC:
blink-reviews, vivekg, abarth-chromium, arv+blink, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move workers' Performance API code to core/timing Historically, Performance API for workers was implemented separately from main thread's. Now, they share a common base class (PerformanceBase), and workers-specific code is relatively small. So let's merge modules/performance into core/timing. BUG=465638 TEST=no functional change; all existing tests should pass Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -554 lines) Patch
M Source/core/core.gypi View 4 chunks +9 lines, -1 line 0 comments Download
A + Source/core/timing/SharedWorkerPerformance.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/SharedWorkerPerformance.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/SharedWorkerPerformance.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/WorkerGlobalScopePerformance.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/WorkerGlobalScopePerformance.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/timing/WorkerGlobalScopePerformance.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/WorkerPerformance.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/WorkerPerformance.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/WorkerPerformance.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/modules/modules.gypi View 3 chunks +0 lines, -8 lines 0 comments Download
D Source/modules/performance/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/modules/performance/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D Source/modules/performance/SharedWorkerPerformance.h View 1 chunk +0 lines, -60 lines 0 comments Download
D Source/modules/performance/SharedWorkerPerformance.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D Source/modules/performance/SharedWorkerPerformance.idl View 1 chunk +0 lines, -33 lines 0 comments Download
D Source/modules/performance/WorkerGlobalScopePerformance.h View 1 chunk +0 lines, -62 lines 0 comments Download
D Source/modules/performance/WorkerGlobalScopePerformance.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
D Source/modules/performance/WorkerGlobalScopePerformance.idl View 1 chunk +0 lines, -33 lines 0 comments Download
D Source/modules/performance/WorkerPerformance.h View 1 chunk +0 lines, -69 lines 0 comments Download
D Source/modules/performance/WorkerPerformance.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D Source/modules/performance/WorkerPerformance.idl View 1 chunk +0 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kunihiko Sakamoto
4 years, 10 months ago (2015-06-17 07:57:12 UTC) #2
Mike West
On 2015/06/17 at 07:57:12, ksakamoto wrote: > LGTM. I'm fine with moving this into core/, ...
4 years, 10 months ago (2015-06-17 08:47:19 UTC) #3
kinuko
Slightly wondered if this could be done the other way around (moving timing code to ...
4 years, 10 months ago (2015-06-17 14:10:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186103003/1
4 years, 10 months ago (2015-06-18 01:23:17 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 01:29:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197303

Powered by Google App Engine
This is Rietveld 408576698