Aura: Browser-side changes for Composite-To-Mailbox

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/string_number_conversions.h"
+#include "cc/compositor_frame.h"
+#include "cc/switches.h"
 #include "content/browser/renderer_host/backing_store_aura.h"
 #include "content/browser/renderer_host/dip_util.h"
 #include "content/browser/renderer_host/overscroll_controller.h"
 #include "content/browser/renderer_host/render_view_host_delegate.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/ui_events_helper.h"
 #include "content/browser/renderer_host/web_input_event_aura.h"
 #include "content/common/gpu/client/gl_helper.h"
 #include "content/common/gpu/gpu_messages.h"
 #include "content/common/view_messages.h"
@@ skipping 847 matching lines @@
     on_compositing_did_commit_callbacks_.push_back(
         base::Bind(&RenderWidgetHostViewAura::InsertSyncPointAndACK, params));
     if (!compositor->HasObserver(this))
       compositor->AddObserver(this);
   }
 }
 
 void RenderWidgetHostViewAura::AcceleratedSurfaceBuffersSwapped(
     const GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params& params_in_pixel,
     int gpu_host_id) {
-  const gfx::Rect surface_rect = gfx::Rect(gfx::Point(), params_in_pixel.size);
-  BufferPresentedParams ack_params(params_in_pixel.route_id, gpu_host_id);
+  BuffersSwapped(params_in_pixel.size, params_in_pixel.mailbox_name,
+                 params_in_pixel.route_id, gpu_host_id);
+}
+
+void RenderWidgetHostViewAura::OnSwapCompositorFrame(
+    const cc::CompositorFrame& frame, int render_host_id, int route_id) {
+  static bool composite_to_mailbox =
+    CommandLine::ForCurrentProcess()->HasSwitch(
+        cc::switches::kCompositeToMailbox);

[piman, 2013/01/18 02:14:11]

Do we need to test the command line here? Should we instead rely on whether
frame.gl_frame_data is set? We'll have another path for the
delegated_frame_data, and it seems superfluous to test the command line instead
of "do what's necessary based on the data we got"

[no sievers, 2013/02/06 23:36:00]

Done.

+  if (!composite_to_mailbox)
+    return;
+
+  DCHECK(!frame.gl_frame_data->size.IsEmpty());
+  DCHECK(!frame.gl_frame_data->mailbox.isZero());
+  DCHECK(frame.gl_frame_data->sync_point);
+
+  ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
+  factory->WaitSyncPoint(frame.gl_frame_data->sync_point);
+
+  std::string mailbox_name;
+  mailbox_name.assign(

[piman, 2013/01/18 02:14:11]

nit: you can just use the constructor with the same parameters

[no sievers, 2013/02/06 23:36:00]

Done.

+      reinterpret_cast<const char*>(frame.gl_frame_data->mailbox.name),
+      sizeof(frame.gl_frame_data->mailbox.name));
+  BuffersSwapped(frame.gl_frame_data->size,
+                 mailbox_name,
+                 route_id,
+                 render_host_id);
+}
+
+void RenderWidgetHostViewAura::BuffersSwapped(
+    const gfx::Size& size,
+    const std::string& mailbox_name,
+    int route_id,
+    int host_id) {
+  const gfx::Rect surface_rect = gfx::Rect(gfx::Point(), size);
+  BufferPresentedParams ack_params(route_id, host_id);
   if (!SwapBuffersPrepare(
-      surface_rect, surface_rect, params_in_pixel.mailbox_name, &ack_params))
+      surface_rect, surface_rect, mailbox_name, &ack_params))
     return;
 
   previous_damage_.setRect(RectToSkIRect(surface_rect));
   skipped_damage_.setEmpty();
 
   ui::Compositor* compositor = GetCompositor();
   if (compositor) {
-    gfx::Size surface_size = ConvertSizeToDIP(this, params_in_pixel.size);
+    gfx::Size surface_size = ConvertSizeToDIP(this, size);
     window_->SchedulePaintInRect(gfx::Rect(surface_size));
   }
 
   SwapBuffersCompleted(ack_params);
 }
 
 void RenderWidgetHostViewAura::AcceleratedSurfacePostSubBuffer(
     const GpuHostMsg_AcceleratedSurfacePostSubBuffer_Params& params_in_pixel,
     int gpu_host_id) {
   const gfx::Rect surface_rect =
@@ skipping 1086 matching lines @@
     RenderWidgetHost* widget) {
   return new RenderWidgetHostViewAura(widget);
 }
 
 // static
 void RenderWidgetHostViewPort::GetDefaultScreenInfo(WebScreenInfo* results) {
   GetScreenInfoForWindow(results, NULL);
 }
 
 }  // namespace content