Expose the capturePicture feature in RenderView for Android WebView legacy API support.

content/common/swapped_out_messages.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/swapped_out_messages.h"
 
 #include "content/common/accessibility_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/common/content_client.h"
 
@@ skipping 18 matching lines @@
     case ViewHostMsg_ClosePage_ACK::ID:
     case ViewHostMsg_DomOperationResponse::ID:
     // Allow cross-process JavaScript calls.
     case ViewHostMsg_RouteCloseEvent::ID:
     case ViewHostMsg_RouteMessageEvent::ID:
       return true;
     default:
       break;
   }
 
-  return false;

[mkosiba (inactive), 2013/02/14 14:03:16]

I think it might be fine to simply say that replies to sync messages are always
allowed rather than adding yet another method to the content/ API.

I don't think such a change could 'hurt' the rest of Chromium since, IIRC,
outside of WebView, the channel would disallow a sync message anyway, right?

[Leandro Graciá Gil, 2013/02/14 14:25:14]

I think the question is if renderer -> browser synchronous IPC messages should
send back a reply to renderers being swapped out. If that's fine or we simply
don't care because other cases won't use a sync channel, then we probably want
to add IPC_REPLY_ID here rather than adding a new API.

Is there any other code in Chrome triggering browser -> renderer synchronous
IPCs? We do only for legacy WebView API compatibility.

+  // Check with the embedder as well.
+  ContentClient* client = GetContentClient();
+  return client->CanSendWhileSwappedOut(msg);
 }
 
 bool SwappedOutMessages::CanHandleWhileSwappedOut(
     const IPC::Message& msg) {
   // Any message the renderer is allowed to send while swapped out should
   // be handled by the browser.
   if (CanSendWhileSwappedOut(&msg))
     return true;
 
   // We drop most other messages that arrive from a swapped out renderer.
@@ skipping 29 matching lines @@
     default:
       break;
   }
 
   // Check with the embedder as well.
   ContentClient* client = GetContentClient();
   return client->CanHandleWhileSwappedOut(msg);
 }
 
 }  // namespace content