Issue 11861006: Consistently use V8EXPORT on all classes and not on individual methods.

Issue 11861006: Consistently use V8EXPORT on all classes and not on individual methods. (Closed)

Created:
7 years, 11 months ago by Sven Panne

Modified:
7 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Consistently use V8EXPORT on all classes and not on individual methods. Committed: http://code.google.com/p/v8/source/detail?r=13365

Patch Set 2 : Rebased + feedback #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+214 lines, -226 lines)			Patch
	M	include/v8.h	View	1	32 chunks	+214 lines, -226 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a couple of comments. https://codereview.chromium.org/11861006/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode1122 include/v8.h:1122: int start = ...

7 years, 11 months ago (2013-01-11 14:06:33 UTC) #2

Sven Panne

7 years, 11 months ago (2013-01-14 07:35:54 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11861006/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode1122
include/v8.h:1122: int start = 0,
On 2013/01/11 14:06:33, Michael Starzinger wrote:
> Indentation is off.

Done.

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode1127
include/v8.h:1127: int start = 0,
On 2013/01/11 14:06:33, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode1132
include/v8.h:1132: int length = -1,
On 2013/01/11 14:06:33, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode1249
include/v8.h:1249: const ExternalAsciiStringResource*
GetExternalAsciiStringResource()
On 2013/01/11 14:06:33, Michael Starzinger wrote:
> Fits into one line now.

Done.

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode1396
include/v8.h:1396: Encoding encoding) const;
On 2013/01/11 14:06:33, Michael Starzinger wrote:
> Indentation is off.

Done.

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode4155
include/v8.h:4155: class V8EXPORT Internals {
On 2013/01/11 14:06:33, Michael Starzinger wrote:
> This class should not be exported since it should not be used externally.

Done.

Expand Messages | Collapse Messages