Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: LayoutTests/inspector/console/console-format.html

Issue 1186093002: [DevTools] Fixed multiline error messages (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added test Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector/console/console-format.html
diff --git a/LayoutTests/inspector/console/console-format.html b/LayoutTests/inspector/console/console-format.html
index d6759a679247c19a3224a211ee9c822de4eccdf2..c3a637185c0b914cc19cb7b79049c0600f318a03 100644
--- a/LayoutTests/inspector/console/console-format.html
+++ b/LayoutTests/inspector/console/console-format.html
@@ -41,6 +41,7 @@ function onload()
var str2 = "test named \"test\"";
var error = new Error;
var errorWithMessage = new Error("my error message");
+ var errorWithMultilineMessage = new Error("my multiline\nerror message");
var node = document.getElementById("p");
var func = function() { return 1; };
var multilinefunc = function() {
@@ -67,8 +68,8 @@ function onload()
var bigTypedArray = new Uint8Array(new ArrayBuffer(400 * 1000 * 1000));
bigTypedArray["FAIL"] = "FAIL: Object.getOwnPropertyNames() should not have been run";
globals = [
- regex1, regex2, str, str2, error, errorWithMessage, node, func, multilinefunc, num, linkify,
- null, undefined, valuelessAttribute, valuedAttribute, existingAttribute, throwingLengthGetter,
+ regex1, regex2, str, str2, error, errorWithMessage, errorWithMultilineMessage, node, func, multilinefunc,
+ num, linkify, null, undefined, valuelessAttribute, valuedAttribute, existingAttribute, throwingLengthGetter,
NaN, Number.POSITIVE_INFINITY, Number.NEGATIVE_INFINITY, array, {}, [function() {}], bar, svg,
objectWithNonEnumerables, negZero, Object.create(null), Object, Object.prototype, arrayLikeFunction,
new Number(42), new String("abc"), new Uint16Array([1, 2, 3]), textNode, domException(),
@@ -110,7 +111,7 @@ function test()
function onRemoteObjectsLoaded()
{
- InspectorTest.expandConsoleMessages(finish, undefined, function(section) { return section.element.firstChild.textContent !== "#text"; });
+ InspectorTest.expandConsoleMessages(InspectorTest.expandConsoleMessagesErrorParameters.bind(this, finish), undefined, function(section) { return section.element.firstChild.textContent !== "#text"; });
}
function finish()

Powered by Google App Engine
This is Rietveld 408576698