[DevTools] Fixed multiline error messages

[DevTools] Fixed multiline error messages

BUG=498806
R=yurys@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197264

[kozy, 2015-06-15 13:42:50]

Yury, please take a look.

[yurys, 2015-06-15 14:21:52]

Please provide a test for the multiline error message.

https://codereview.chromium.org/1186093002/diff/1/Source/core/inspector/Injec...
File Source/core/inspector/InjectedScriptSource.js (right):

https://codereview.chromium.org/1186093002/diff/1/Source/core/inspector/Injec...
Source/core/inspector/InjectedScriptSource.js:1215: var firstCallFrame =
/^\s*at\s/m.exec(stack);
I believe stack frames always start with " at ", i.e. one space before "at" and
ends with :\d+:\d\), can we provide more strict regex?
Also it might make sense to cache the regex.

[kozy, 2015-06-16 10:22:53]

https://codereview.chromium.org/1186093002/diff/1/Source/core/inspector/Injec...
File Source/core/inspector/InjectedScriptSource.js (right):

https://codereview.chromium.org/1186093002/diff/1/Source/core/inspector/Injec...
Source/core/inspector/InjectedScriptSource.js:1215: var firstCallFrame =
/^\s*at\s/m.exec(stack);
On 2015/06/15 14:21:51, yurys wrote:
> I believe stack frames always start with " at ", i.e. one space before "at"
and
> ends with :\d+:\d\), can we provide more strict regex?
> Also it might make sense to cache the regex.
> 

Yes, it starts from spaces. This line is generated in [1]. Done.
End of string is generated in [2] and it isn't contain ending with :\d in all
cases.
In devtools source code we've already one regex for call frame in
ConsoleViewMessages.js [3]: var isCallFrameLine = /^\s*at\s/.test(lines[i]);

We use regex in InjectedScriptSource without caching for generating preview of
element nodes. I suppose that we can ignore it here too.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/messages.js...
[2]
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/messages.js...
[3]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[yurys, 2015-06-16 10:38:42]

lgtm given there is a test for multi-line message.

[kozy, 2015-06-17 13:15:36]

Patchset #3 (id:40001) has been deleted

[kozy, 2015-06-17 13:16:16]

Added test.

[kozy, 2015-06-17 13:16:21]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2015-06-17 13:16:22]

The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/1186093002/#ps60001
(title: "Added test")

[commit-bot: I haz the power, 2015-06-17 13:16:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1186093002/60001

[yurys, 2015-06-17 13:20:23]

https://codereview.chromium.org/1186093002/diff/60001/Source/devtools/front_e...
File Source/devtools/front_end/console/ConsoleViewMessage.js (right):

https://codereview.chromium.org/1186093002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/console/ConsoleViewMessage.js:627:
detailedLink._showDetailedForTest = showDetailed.bind(null, new
MouseEvent('click'));
Why not make showDetails a method instead?

[commit-bot: I haz the power, 2015-06-17 14:36:47]

Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197264