Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: Source/devtools/front_end/emulation/OverridesView.js

Issue 1186083003: [DevTools] Move network throttling to network panel. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Merged in device mode Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/emulation/OverridesView.js
diff --git a/Source/devtools/front_end/emulation/OverridesView.js b/Source/devtools/front_end/emulation/OverridesView.js
index c2ab9527906684e0674c52c11563873c419c3700..b29651b09c4fe892c8ef3abcb6d9dace668fab49 100644
--- a/Source/devtools/front_end/emulation/OverridesView.js
+++ b/Source/devtools/front_end/emulation/OverridesView.js
@@ -302,9 +302,8 @@ WebInspector.OverridesView.MediaTab.prototype = {
*/
WebInspector.OverridesView.NetworkTab = function()
{
- WebInspector.OverridesView.Tab.call(this, "network", WebInspector.UIString("Network"), [], [this._userAgentOverrideEnabled.bind(this), this._networkThroughputIsLimited.bind(this)]);
+ WebInspector.OverridesView.Tab.call(this, "network", WebInspector.UIString("Network"), [], [this._userAgentOverrideEnabled.bind(this)]);
this.element.classList.add("overrides-network");
- this._createNetworkConditionsElement();
this._createUserAgentSection();
}
@@ -312,24 +311,6 @@ WebInspector.OverridesView.NetworkTab.prototype = {
/**
* @return {boolean}
*/
- _networkThroughputIsLimited: function()
- {
- return WebInspector.overridesSupport.networkThroughputIsLimited();
- },
-
- _createNetworkConditionsElement: function()
- {
- var fieldsetElement = this.element.createChild("fieldset");
- fieldsetElement.createChild("span").textContent = WebInspector.UIString("Limit network throughput:");
- fieldsetElement.createChild("br");
- fieldsetElement.appendChild(WebInspector.OverridesUI.createNetworkConditionsSelect());
-
- WebInspector.overridesSupport.settings.networkConditions.addChangeListener(this.updateActiveState, this);
- },
-
- /**
- * @return {boolean}
- */
_userAgentOverrideEnabled: function()
{
return !!WebInspector.overridesSupport.settings.userAgent.get();
« no previous file with comments | « Source/devtools/front_end/emulation/OverridesUI.js ('k') | Source/devtools/front_end/emulation/ResponsiveDesignView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698