Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1186083003: [DevTools] Move network throttling to network panel. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Move network throttling to network panel. BUG=500225 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197352

Patch Set 1 #

Patch Set 2 : Merged in device mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -191 lines) Patch
M Source/devtools/front_end/emulation/OverridesSupport.js View 7 chunks +0 lines, -36 lines 0 comments Download
M Source/devtools/front_end/emulation/OverridesUI.js View 2 chunks +0 lines, -78 lines 0 comments Download
M Source/devtools/front_end/emulation/OverridesView.js View 2 chunks +1 line, -20 lines 0 comments Download
M Source/devtools/front_end/emulation/ResponsiveDesignView.js View 1 2 chunks +13 lines, -19 lines 0 comments Download
M Source/devtools/front_end/emulation/responsiveDesignView.css View 1 2 chunks +5 lines, -20 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 2 chunks +65 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkManager.js View 5 chunks +44 lines, -18 lines 0 comments Download
M Source/devtools/front_end/ui/Toolbar.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
dgozman
Take a look please.
4 years, 10 months ago (2015-06-16 13:33:28 UTC) #2
dgozman
On 2015/06/16 13:33:28, dgozman wrote: > Take a look please. Screenshot: http://pasteboard.co/1gxHCY2V.png
4 years, 10 months ago (2015-06-16 13:33:52 UTC) #3
pfeldman
On 2015/06/16 13:33:52, dgozman wrote: > On 2015/06/16 13:33:28, dgozman wrote: > > Take a ...
4 years, 10 months ago (2015-06-16 18:36:18 UTC) #4
dgozman
On 2015/06/16 18:36:18, pfeldman wrote: > On 2015/06/16 13:33:52, dgozman wrote: > > On 2015/06/16 ...
4 years, 10 months ago (2015-06-16 18:43:18 UTC) #5
pfeldman
I think you can leave it as a r/o subtle text to the right, but ...
4 years, 10 months ago (2015-06-16 18:45:19 UTC) #6
dgozman
PTAL. Screenshot: http://pasteboard.co/1i56iz5h.png.
4 years, 10 months ago (2015-06-17 13:47:56 UTC) #7
pfeldman
On 2015/06/17 13:47:56, dgozman wrote: > PTAL. Screenshot: http://pasteboard.co/1i56iz5h.png. Can't load it, pasteboard is down.
4 years, 10 months ago (2015-06-18 06:54:38 UTC) #8
pfeldman
lgtm
4 years, 10 months ago (2015-06-18 12:19:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186083003/20001
4 years, 10 months ago (2015-06-18 12:19:37 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 13:29:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197352

Powered by Google App Engine
This is Rietveld 408576698