Issue 11860015: Fix LevelDB histogram code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11860015: Fix LevelDB histogram code. (Closed)

Created:
7 years, 11 months ago by dgrogan

Modified:
7 years, 11 months ago

Reviewers:
jsbell

CC:
chromium-reviews, alecflett

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix LevelDB histogram code. The old code misused the macros provided by histogram.h such that a DCHECK failed on the bots. UMA_HISTOGRAM_ENUMERATION et al use a static variable to retrieve the Histogram objects, so a single instance of that macro can't be used to retrieve multiple histograms. The old code tried to retrieve both LevelDBEnv.IOError and LevelDBEnv.IDB.IOError. This CL forgoes use of the macro and keeps a pointer to the Histogram objects around. http://wkb.ug/106135 will have to reland to make use of this. BUG=164755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176577