sdk/lib/_internal/compiler/implementation/ssa/builder.dart - Issue 11860008: Stop passing library elements to tons of namer functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 11860008: Stop passing library elements to tons of namer functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Diff against https://codereview.chromium.org/11819060/. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/namer.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

index 533727612c17c7ee8063205ce160ad5d851b31ad..e48d33590690450e977feb7d6f332373a7d1d000 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

@@ -3104,7 +3104,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

}

visit(closure);

List<HInstruction> inputs = <HInstruction>[pop()];

- String invocationName = backend.namer.closureInvocationName(

+ String invocationName = backend.namer.invocationName(

new Selector.callClosure(params.requiredParameterCount));

push(new HForeign(new DartString.literal('#.$invocationName'),

const LiteralDartString('var'),

@@ -3175,8 +3175,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

Constant nameConstant = constantSystem.createString(

new DartString.literal(name.slowToString()), node);

- String internalName = backend.namer.instanceMethodInvocationName(

- currentLibrary, name, selector);

+ String internalName = backend.namer.invocationName(selector);

Constant internalNameConstant =

constantSystem.createString(new DartString.literal(internalName), node);