ui/base/resource/data_pack_unittest.cc - Issue 1185973003: Take 2: Moved logic for mapping child process FDs for ICU and V8 into child_process_launcher.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/resource/data_pack_unittest.cc

Issue 1185973003: Take 2: Moved logic for mapping child process FDs for ICU and V8 into child_process_launcher.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/resource/data_pack_unittest.cc

diff --git a/ui/base/resource/data_pack_unittest.cc b/ui/base/resource/data_pack_unittest.cc

index 4ab4faa1bb00da32fc7e1156b64d433b1ba14e63..b0932fcef8edd6d5e5bead7ce13d92dcf86b89aa 100644

--- a/ui/base/resource/data_pack_unittest.cc

+++ b/ui/base/resource/data_pack_unittest.cc

@@ -110,7 +110,7 @@ TEST(DataPackTest, LoadFromFileRegion) {

// Load the file through the data pack API.

DataPack pack(SCALE_FACTOR_100P);

- base::MemoryMappedFile::Region region(sizeof(kPadding), kSamplePakSize);

+ base::MemoryMappedFile::Region region = {sizeof(kPadding), kSamplePakSize};

ASSERT_TRUE(pack.LoadFromFileRegion(file.Pass(), region));

base::StringPiece data;

« no previous file with comments | « gin/v8_initializer.cc ('k') | no next file » | no next file with comments »