Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3510)

Unified Diff: base/files/memory_mapped_file.h

Issue 1185973003: Take 2: Moved logic for mapping child process FDs for ICU and V8 into child_process_launcher.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: finish Region refactor Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/memory_mapped_file.h
diff --git a/base/files/memory_mapped_file.h b/base/files/memory_mapped_file.h
index 96d1d91f9359b8c96c9646a444add20be2555472..9ff29b9fef11c74df2136de44d81efe0bd6034e9 100644
--- a/base/files/memory_mapped_file.h
+++ b/base/files/memory_mapped_file.h
@@ -28,9 +28,6 @@ class BASE_EXPORT MemoryMappedFile {
struct BASE_EXPORT Region {
static const Region kWholeFile;
- Region();
- Region(int64 offset, int64 size);
-
bool operator==(const Region& other) const;
jochen (gone - plz use gerrit) 2015/06/18 12:59:21 not needed anymore, no?
agrieve 2015/06/18 13:33:02 I think they are still needed: http://stackoverflo
bool operator!=(const Region& other) const;
@@ -39,10 +36,6 @@ class BASE_EXPORT MemoryMappedFile {
// Length of the region in bytes.
int64 size;
-
- private:
- // Used by kWholeFile.
- Region(base::LinkerInitialized);
};
// Opens an existing file and maps it into memory. Access is restricted to

Powered by Google App Engine
This is Rietveld 408576698