Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1185963004: Revert of Sync Windows build flags between GYP and GN (Closed)

Created:
5 years, 6 months ago by phoglund_chromium
Modified:
5 years, 6 months ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Sync Windows build flags between GYP and GN (patchset #4 id:60001 of https://codereview.chromium.org/1183613006/) Reason for revert: Speculative revert for Linux GN clobber compile failure: FAILED: python ../../remoting/webapp/build-webapp.py ... Traceback (most recent call last): File "../../remoting/webapp/build-webapp.py", line 487, in <module> sys.exit(main()) File "../../remoting/webapp/build-webapp.py", line 483, in main return buildWebApp(**vars(args)) File "../../remoting/webapp/build-webapp.py", line 257, in buildWebApp + buildtype + ': ' + service_environment) Exception: Invalid service_environment targeted for Release: ninja: build stopped: subcommand failed. Original issue's description: > Sync Windows build flags between GYP and GN > > In GN, turn on omtimize:max for base targets on all platforms, not just Android (matches GYP). > > In GN, don't duplicate /Os twice, make standard optimize = /O1 (matches GYP). Don't specify redundant optimization flags that are included as part of /O1 or /O2 (doesn't match GYP flag-wise, but should match functionality-wise). > > In GN, add a min Windows version of XP to x86 architecture binaries (matches GYP). > > In GYP, remove /GT ("EnableFiberSafeOptimizations"). This flag is super old (pre-dates GYP) and was likely turned on because it has the word "optimization" in it. It was only specified in official builds. However, according to the docs, this is making optimizations fiber safe (i.e. slower, by not caching the TLS pointer), rather than enabling optimizations for fibers. We don't use fibers so this flag is unnecessary and may be making TLS access slightly slower. > > Committed: https://crrev.com/67021f4d70fe838a5d78133bc6d5b305dfd70d72 > Cr-Commit-Position: refs/heads/master@{#334742} TBR=scottmg@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1becf72a2d1b5eec4468cc950142b083e9b24fbe Cr-Commit-Position: refs/heads/master@{#334782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M base/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M build/config/compiler/BUILD.gn View 4 chunks +14 lines, -14 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M build/internal/release_impl_official.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
phoglund_chromium
Created Revert of Sync Windows build flags between GYP and GN
5 years, 6 months ago (2015-06-17 06:53:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185963004/1
5 years, 6 months ago (2015-06-17 06:53:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 06:54:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1becf72a2d1b5eec4468cc950142b083e9b24fbe Cr-Commit-Position: refs/heads/master@{#334782}
5 years, 6 months ago (2015-06-17 06:55:07 UTC) #4
phoglund_chromium
5 years, 6 months ago (2015-06-17 09:06:15 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1184953004/ by phoglund@chromium.org.

The reason for reverting is: Appears this was innocent after all. .

Powered by Google App Engine
This is Rietveld 408576698