Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1185963002: Add some Mojo C thunks used by cc when turning on impl-side painting. (Closed)

Created:
5 years, 6 months ago by jam
Modified:
5 years, 6 months ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add some Mojo C thunks used by cc when turning on impl-side painting. I haven't implemented this in Mojo repo as it's not used there. BUG=499030 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f6030acf999785d701259d27dffe774f184e071b

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : update per review #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -13 lines) Patch
M mojo/public/c/gles2/BUILD.gn View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A + mojo/public/c/gles2/chromium_copy_texture.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/public/c/gles2/chromium_image.h View 2 chunks +6 lines, -4 lines 0 comments Download
A + mojo/public/c/gles2/chromium_pixel_transfer_buffer_object.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A mojo/public/c/gles2/gles2_call_visitor_chromium_copy_texture_autogen.h View 1 chunk +31 lines, -0 lines 0 comments Download
A mojo/public/c/gles2/gles2_call_visitor_chromium_image_autogen.h View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A + mojo/public/c/gles2/gles2_call_visitor_chromium_pixel_transfer_buffer_object_autogen.h View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M mojo/public/platform/native/BUILD.gn View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_chromium_copy_texture_thunks.h View 1 chunk +44 lines, -0 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_chromium_copy_texture_thunks.cc View 1 chunk +31 lines, -0 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_chromium_image_thunks.h View 1 chunk +44 lines, -0 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_chromium_image_thunks.cc View 1 chunk +31 lines, -0 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_chromium_pixel_transfer_buffer_object_thunks.h View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_chromium_pixel_transfer_buffer_object_thunks.cc View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jam
5 years, 6 months ago (2015-06-15 17:24:30 UTC) #2
sky
Rubber stamp LGTM
5 years, 6 months ago (2015-06-15 20:39:44 UTC) #3
jam
5 years, 6 months ago (2015-06-16 02:51:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
f6030acf999785d701259d27dffe774f184e071b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698