Remove deferred image decoding code from ImageDecodeBench

Source/platform/image-decoders/ImageDecoder.h

 /*
  * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
  * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 17 matching lines @@
 #define ImageDecoder_h
 
 #include "SkColorPriv.h"
 #include "platform/PlatformExport.h"
 #include "platform/SharedBuffer.h"
 #include "platform/graphics/ImageSource.h"
 #include "platform/image-decoders/ImageAnimation.h"
 #include "platform/image-decoders/ImageFrame.h"
 #include "public/platform/Platform.h"
 #include "wtf/Assertions.h"
+#include "wtf/PassOwnPtr.h"

[Peter Kasting, 2015/06/15 20:18:21]

Nit: If this header compiled without these before, is it really
correct/necessary to move them here?

[Noel Gordon, 2015/06/16 17:53:47]

It's correct from the include-what-you-use standpoint.  Not necessary though,
the header was compiling already, meaning the transitive closure of include
files somehow includes PassOwnPtr and AtomicallyInitializedStaticReference that
ImageDecoder.h uses in-line.

If I remove the extra includes I added to ImageDecoder.h here, but don't include
them in ImageDecodebench.cpp, then the compiler complains ...

nkGCPlugin.dylib -Xclang -add-plugin -Xclang blink-gc-plugin  -c
../../third_party/WebKit/Source/web/ImageDecodeBench.cpp -o
obj/third_party/WebKit/Source/web/image_decode_bench.ImageDecodeBench.o
In file included from
../../third_party/WebKit/Source/web/ImageDecodeBench.cpp:33:
../../third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:241:46:
error: 'OutputDeviceProfile' does not refer to a value
        AtomicallyInitializedStaticReference(OutputDeviceProfile,
outputDeviceProfile, new OutputDeviceProfile);
                            
# missing reference to AtomicallyInitializedStaticReference, it's in
"wtf/Threading.h".

./../third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:282:56:
error: implicit instantiation of undefined template
'WTF::PassOwnPtr<blink::ImagePlanes>'
    virtual void setImagePlanes(PassOwnPtr<ImagePlanes>) { }
                                                       ^
../../third_party/WebKit/Source/wtf/Forward.h:29:32: note: template is declared
here
    template<typename T> class PassOwnPtr;
                               
# missing reference to PassOwnPtr, need <wtf/PassOwnPtr.h>.

So get the bench to compile, I need put those two includes _ahead_ of
ImageDecoder.h it seems. I'm fine with that too and might do that.

 #include "wtf/RefPtr.h"
+#include "wtf/Threading.h"
 #include "wtf/Vector.h"
 #include "wtf/text/WTFString.h"
 
 #if USE(QCMSLIB)
 #include "qcms.h"
 #endif
 
 typedef Vector<char> ColorProfile;
 
 namespace blink {
@@ skipping 293 matching lines @@
 
     IntSize m_size;
     bool m_sizeAvailable;
     bool m_isAllDataReceived;
     bool m_failed;
 };
 
 } // namespace blink
 
 #endif