Remove deferred image decoding code from ImageDecodeBench

Remove deferred image decoding code from ImageDecodeBench

ImageDecodeBench tool does not need or depend on Blink deferred decoding.
Remove code references to deferred decoding. Minor: fix spelling.

BUG=492961, 413479
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197321

[Noel Gordon, 2015-06-13 14:02:51]

noel@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-06-15 20:18:22]

LGTM

https://codereview.chromium.org/1185933002/diff/1/Source/platform/image-decod...
File Source/platform/image-decoders/ImageDecoder.h (right):

https://codereview.chromium.org/1185933002/diff/1/Source/platform/image-decod...
Source/platform/image-decoders/ImageDecoder.h:38: #include "wtf/PassOwnPtr.h"
Nit: If this header compiled without these before, is it really
correct/necessary to move them here?

[scroggo_chromium, 2015-06-15 20:21:25]

scroggo@chromium.org changed reviewers:
+ scroggo@chromium.org

[scroggo_chromium, 2015-06-15 20:21:26]

lgtm

[Noel Gordon, 2015-06-16 17:53:47]

https://codereview.chromium.org/1185933002/diff/1/Source/platform/image-decod...
File Source/platform/image-decoders/ImageDecoder.h (right):

https://codereview.chromium.org/1185933002/diff/1/Source/platform/image-decod...
Source/platform/image-decoders/ImageDecoder.h:38: #include "wtf/PassOwnPtr.h"
On 2015/06/15 20:18:21, Peter Kasting wrote:
> Nit: If this header compiled without these before, is it really
> correct/necessary to move them here?

It's correct from the include-what-you-use standpoint.  Not necessary though,
the header was compiling already, meaning the transitive closure of include
files somehow includes PassOwnPtr and AtomicallyInitializedStaticReference that
ImageDecoder.h uses in-line.

If I remove the extra includes I added to ImageDecoder.h here, but don't include
them in ImageDecodebench.cpp, then the compiler complains ...

nkGCPlugin.dylib -Xclang -add-plugin -Xclang blink-gc-plugin  -c
../../third_party/WebKit/Source/web/ImageDecodeBench.cpp -o
obj/third_party/WebKit/Source/web/image_decode_bench.ImageDecodeBench.o
In file included from
../../third_party/WebKit/Source/web/ImageDecodeBench.cpp:33:
../../third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:241:46:
error: 'OutputDeviceProfile' does not refer to a value
        AtomicallyInitializedStaticReference(OutputDeviceProfile,
outputDeviceProfile, new OutputDeviceProfile);
                            
# missing reference to AtomicallyInitializedStaticReference, it's in
"wtf/Threading.h".

./../third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:282:56:
error: implicit instantiation of undefined template
'WTF::PassOwnPtr<blink::ImagePlanes>'
    virtual void setImagePlanes(PassOwnPtr<ImagePlanes>) { }
                                                       ^
../../third_party/WebKit/Source/wtf/Forward.h:29:32: note: template is declared
here
    template<typename T> class PassOwnPtr;
                               
# missing reference to PassOwnPtr, need <wtf/PassOwnPtr.h>.

So get the bench to compile, I need put those two includes _ahead_ of
ImageDecoder.h it seems. I'm fine with that too and might do that.

[Noel Gordon, 2015-06-16 17:55:15]

The CQ bit was checked by noel@chromium.org

[Noel Gordon, 2015-06-16 17:55:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
scroggo@chromium.org, pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1185933002/#ps20001
(title: "Remove changes to ImageDecoder.h")

[commit-bot: I haz the power, 2015-06-16 17:55:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1185933002/20001

[Noel Gordon, 2015-06-16 17:56:50]

noel@chromium.org changed reviewers:
+ pdr@chromium.org

[Noel Gordon, 2015-06-16 17:56:51]

+pdr, will need you approve too to land I think.

[commit-bot: I haz the power, 2015-06-16 18:01:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 18:01:30]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[Peter Kasting, 2015-06-16 21:29:03]

https://codereview.chromium.org/1185933002/diff/20001/Source/web/ImageDecodeB...
File Source/web/ImageDecodeBench.cpp (right):

https://codereview.chromium.org/1185933002/diff/20001/Source/web/ImageDecodeB...
Source/web/ImageDecodeBench.cpp:31: #include "wtf/PassOwnPtr.h"
These should all be in alphabetical order.  If putting them that way breaks the
compile, then various headers need to have their #includes updated.

[Noel Gordon, 2015-06-17 11:14:44]

https://codereview.chromium.org/1185933002/diff/20001/Source/web/ImageDecodeB...
File Source/web/ImageDecodeBench.cpp (right):

https://codereview.chromium.org/1185933002/diff/20001/Source/web/ImageDecodeB...
Source/web/ImageDecodeBench.cpp:31: #include "wtf/PassOwnPtr.h"
On 2015/06/16 21:29:03, Peter Kasting wrote:
> These should all be in alphabetical order.  

Exactly.

> If putting them that way breaks the
> compile, then various headers need to have their #includes updated.

Yes, and why I updated ImageDecode.h in patch set #1 :)

[Peter Kasting, 2015-06-17 20:20:43]

On 2015/06/17 11:14:44, noel gordon wrote:
>
https://codereview.chromium.org/1185933002/diff/20001/Source/web/ImageDecodeB...
> File Source/web/ImageDecodeBench.cpp (right):
> 
>
https://codereview.chromium.org/1185933002/diff/20001/Source/web/ImageDecodeB...
> Source/web/ImageDecodeBench.cpp:31: #include "wtf/PassOwnPtr.h"
> On 2015/06/16 21:29:03, Peter Kasting wrote:
> > These should all be in alphabetical order.  
> 
> Exactly.
> 
> > If putting them that way breaks the
> > compile, then various headers need to have their #includes updated.
> 
> Yes, and why I updated ImageDecode.h in patch set #1 :)

OK, then update it.  If the only reason it previously compiled is that some
consumers violated include ordering rules, that should be fixed.

[Noel Gordon, 2015-06-18 04:21:53]

On 2015/06/17 20:20:43, Peter Kasting wrote:
> > > If putting them that way breaks the
> > > compile, then various headers need to have their #includes updated.
> > 
> > Yes, and why I updated ImageDecode.h in patch set #1 :)
> 
> OK, then update it.  If the only reason it previously compiled is that some
> consumers violated include ordering rules, that should be fixed.

OK thanks. Deleting patch set #2, will submit patch set #1.

[Noel Gordon, 2015-06-18 04:22:15]

Patchset #2 (id:20001) has been deleted

[Noel Gordon, 2015-06-18 04:24:01]

noel@chromium.org changed reviewers:
+ tkent@chromium.org

[Noel Gordon, 2015-06-18 04:25:34]

+tkent, need your approval to submit.

[tkent, 2015-06-18 04:57:53]

lgtm

[Noel Gordon, 2015-06-18 05:03:41]

The CQ bit was checked by noel@chromium.org

[commit-bot: I haz the power, 2015-06-18 05:04:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1185933002/1

[commit-bot: I haz the power, 2015-06-18 06:20:46]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197321