Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: Source/core/layout/HitTestResult.h

Issue 1185923002: Oilpan: fix build after r197063, move HitTestCache to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add TODO for HitTestResult's trait override Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/layout/HitTestCache.cpp ('k') | Source/core/layout/LayoutView.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. 2 * Copyright (C) 2006 Apple Computer, Inc.
3 * Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 16 matching lines...) Expand all
27 #include "core/layout/HitTestRequest.h" 27 #include "core/layout/HitTestRequest.h"
28 #include "platform/geometry/FloatQuad.h" 28 #include "platform/geometry/FloatQuad.h"
29 #include "platform/geometry/FloatRect.h" 29 #include "platform/geometry/FloatRect.h"
30 #include "platform/geometry/LayoutRect.h" 30 #include "platform/geometry/LayoutRect.h"
31 #include "platform/heap/Handle.h" 31 #include "platform/heap/Handle.h"
32 #include "platform/text/TextDirection.h" 32 #include "platform/text/TextDirection.h"
33 #include "wtf/Forward.h" 33 #include "wtf/Forward.h"
34 #include "wtf/ListHashSet.h" 34 #include "wtf/ListHashSet.h"
35 #include "wtf/OwnPtr.h" 35 #include "wtf/OwnPtr.h"
36 #include "wtf/RefPtr.h" 36 #include "wtf/RefPtr.h"
37 #include "wtf/VectorTraits.h"
37 38
38 namespace blink { 39 namespace blink {
39 40
40 class Element; 41 class Element;
41 class LocalFrame; 42 class LocalFrame;
42 class HTMLAreaElement; 43 class HTMLAreaElement;
43 class HTMLMediaElement; 44 class HTMLMediaElement;
44 class Image; 45 class Image;
45 class KURL; 46 class KURL;
46 class Node; 47 class Node;
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 // determine where inside the layoutObject we hit on subsequent operatio ns. 166 // determine where inside the layoutObject we hit on subsequent operatio ns.
166 RefPtrWillBeMember<Element> m_innerURLElement; 167 RefPtrWillBeMember<Element> m_innerURLElement;
167 RefPtrWillBeMember<Scrollbar> m_scrollbar; 168 RefPtrWillBeMember<Scrollbar> m_scrollbar;
168 bool m_isOverWidget; // Returns true if we are over a widget (and not in the border/padding area of a LayoutPart for example). 169 bool m_isOverWidget; // Returns true if we are over a widget (and not in the border/padding area of a LayoutPart for example).
169 170
170 mutable OwnPtrWillBeMember<NodeSet> m_listBasedTestResult; 171 mutable OwnPtrWillBeMember<NodeSet> m_listBasedTestResult;
171 }; 172 };
172 173
173 } // namespace blink 174 } // namespace blink
174 175
176 #if ENABLE(OILPAN)
177 // TODO(sof): the trait override/specialization is needed by HitTestCache's
178 // HeapVector<> to handle unused slots. It is not correct for HitTestResult
179 // in the wider sense of what canInitializeWithMemset provides, so fix this
180 // by introducing a trait that encompasses "unused slot" handling and use it
181 // here instead.
182 //
183 // Until that time, make this trait specialization conditional on OILPAN to
184 // limit exposure.
185 WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS(blink::HitTestResult);
186 #endif
187
175 #endif // HitTestResult_h 188 #endif // HitTestResult_h
OLDNEW
« no previous file with comments | « Source/core/layout/HitTestCache.cpp ('k') | Source/core/layout/LayoutView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698