Add a way to specify different source urls for the component updater

Add a way to specify different source urls for the component updater

So components can be installed from the chrome web store or from
some limited set of options which are controlled by an enum.

Currentlyt the options are omaha (bandaid) the chrome webstore and
the sandbox webstore.

BUG=171079
TEST=see bug, added unittest.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178360

[cpu_(ooo_6.6-7.5), 2013-01-21 02:47:19]

simple enhancement to the component updater, I left some breadcrumbs in the
review to make it easy to review.

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
File chrome/browser/component_updater/component_updater_configurator.cc (left):

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_configurator.cc:142: }
this was a hack put in place for pnacl, there is no need for this anymore as
this CL offers a better way.

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
File chrome/browser/component_updater/component_updater_service.cc (right):

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_service.cc:227:
source(BANDAID) {
the default source is the current one so I don't have to change all the
consumers.

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_service.cc:529: 
this new for loop is the meat of the change. Basically the code mostly stays the
same except that 518-575 block is now done potentially 3 times
(arraysize(kManifestSources))

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
File chrome/browser/component_updater/component_updater_service.h (right):

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_service.h:66: UrlSource
source;
this new member is the only visible change for the consumers of the component
updater.

[asargent_no_longer_on_chrome, 2013-01-23 17:58:32]

LGTM

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
File chrome/browser/component_updater/component_updater_service.cc (right):

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_service.cc:534: // If no
pending upgrades, we check the if there are new
typo: "we check the if there"

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_service.cc:570: // we have
not checked them recently.
typo: comment should say "..updated as long as we ..." (missing the second 'as')

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_service.cc:583: }
I assume that work_items_ will always be very short right?

(If it were going to be very long, I'd say we'd want to avoid iterating over it
3 separate times inside the body of the outer for loop since this CL now makes
it 9 times total; perhaps by separating into separate lists based on
item->status).

[cpu_(ooo_6.6-7.5), 2013-01-23 18:56:06]

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
File chrome/browser/component_updater/component_updater_service.cc (right):

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_service.cc:534: // If no
pending upgrades, we check the if there are new
On 2013/01/23 17:58:32, Antony Sargent wrote:
> typo: "we check the if there"

Done.

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_service.cc:570: // we have
not checked them recently.
On 2013/01/23 17:58:32, Antony Sargent wrote:
> typo: comment should say "..updated as long as we ..." (missing the second
'as')

Done.

https://codereview.chromium.org/11859044/diff/12001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_service.cc:583: }
Yep, currently at 4 items.

On 2013/01/23 17:58:32, Antony Sargent wrote:
> I assume that work_items_ will always be very short right?
> 
> (If it were going to be very long, I'd say we'd want to avoid iterating over
it
> 3 separate times inside the body of the outer for loop since this CL now makes
> it 9 times total; perhaps by separating into separate lists based on
> item->status). 
>