Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1872)

Unified Diff: ppapi/proxy/device_enumeration_resource_helper.cc

Issue 11859015: Pepper: Introduce ThreadAwareCallback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes in response to David's suggestions Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/device_enumeration_resource_helper.cc
diff --git a/ppapi/proxy/device_enumeration_resource_helper.cc b/ppapi/proxy/device_enumeration_resource_helper.cc
index 2b51c27fb47eb3acc5b9588f9e82752460927caf..b9d9f31758b9867f90f1016623cf23b03e5538e0 100644
--- a/ppapi/proxy/device_enumeration_resource_helper.cc
+++ b/ppapi/proxy/device_enumeration_resource_helper.cc
@@ -30,7 +30,6 @@ DeviceEnumerationResourceHelper::DeviceEnumerationResourceHelper(
: owner_(owner),
pending_enumerate_devices_(false),
monitor_callback_id_(0),
- monitor_callback_(NULL),
monitor_user_data_(NULL) {
}
@@ -90,7 +89,8 @@ int32_t DeviceEnumerationResourceHelper::MonitorDeviceChange(
PP_MonitorDeviceChangeCallback callback,
void* user_data) {
monitor_callback_id_++;
- monitor_callback_ = callback;
+ monitor_callback_.reset(
+ new ThreadAwareCallback<PP_MonitorDeviceChangeCallback>(callback));
monitor_user_data_ = user_data;
if (callback) {
@@ -120,7 +120,7 @@ bool DeviceEnumerationResourceHelper::HandleReply(
void DeviceEnumerationResourceHelper::LastPluginRefWasDeleted() {
// Make sure that no further notifications are sent to the plugin.
monitor_callback_id_++;
- monitor_callback_ = NULL;
+ monitor_callback_.reset();
monitor_user_data_ = NULL;
// There is no need to do anything with pending callback of
@@ -178,7 +178,7 @@ void DeviceEnumerationResourceHelper::OnPluginMsgNotifyDeviceChange(
return;
}
- CHECK(monitor_callback_);
+ CHECK(monitor_callback_.get());
scoped_array<PP_Resource> elements;
uint32_t size = devices.size();
@@ -191,10 +191,8 @@ void DeviceEnumerationResourceHelper::OnPluginMsgNotifyDeviceChange(
}
}
- // TODO(yzshen): make sure |monitor_callback_| is called on the same thread as
- // the one on which MonitorDeviceChange() is called.
- CallWhileUnlocked(base::Bind(monitor_callback_, monitor_user_data_, size,
- elements.get()));
+ monitor_callback_->RunOnTargetThread(monitor_user_data_, size,
+ elements.get());
for (size_t index = 0; index < size; ++index)
PpapiGlobals::Get()->GetResourceTracker()->ReleaseResource(elements[index]);
}

Powered by Google App Engine
This is Rietveld 408576698