Pepper: Introduce ThreadAwareCallback.

ppapi/shared_impl/ppapi_globals.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_SHARED_IMPL_PPAPI_GLOBALS_H_
 #define PPAPI_SHARED_IMPL_PPAPI_GLOBALS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 25 matching lines @@
 // Abstract base class
 class PPAPI_SHARED_EXPORT PpapiGlobals {
  public:
   // Must be created on the main thread.
   PpapiGlobals();
 
   // This constructor is to be used only for making a PpapiGlobal for testing
   // purposes. This avoids setting the global static ppapi_globals_. For unit
   // tests that use this feature, the "test" PpapiGlobals should be constructed
   // using this method. See SetPpapiGlobalsOnThreadForTest for more information.
-  struct ForTest {};
-  explicit PpapiGlobals(ForTest);
+  struct ForPerThreadTest {};

[dmichael (off chromium), 2013/01/15 22:43:52]

Since it's really the PpapiGlobals that's "Per-thread", not the test, how about:
PerThreadForTest

(That also leaves "ForTest" together, which makes it clearer, since a ForTest
suffix is meaningful in Chromium)

[yzshen1, 2013/01/16 18:55:59]

Done.

+  explicit PpapiGlobals(ForPerThreadTest);
 
   virtual ~PpapiGlobals();
 
   // Getter for the global singleton.
   inline static PpapiGlobals* Get() {
     if (ppapi_globals_)
       return ppapi_globals_;
     // In unit tests, the following might be valid (see
     // SetPpapiGlobalsOnThreadForTest). Normally, this will just return NULL.
     return GetThreadLocalPointer();
   }
 
   // This allows us to set a given PpapiGlobals object as the PpapiGlobals for
   // a given thread. After setting the PpapiGlobals for a thread, Get() will
   // return that PpapiGlobals when Get() is called on that thread. Other threads
   // are unaffected. This allows us to have tests which use >1 PpapiGlobals in
   // the same process, e.g. for having 1 thread emulate the "host" and 1 thread
   // emulate the "plugin".
   //
-  // PpapiGlobals object must have been constructed using the "ForTest"
+  // PpapiGlobals object must have been constructed using the "ForPerThreadTest"
   // parameter.
   static void SetPpapiGlobalsOnThreadForTest(PpapiGlobals* ptr);
 
   // Retrieves the corresponding tracker.
   virtual ResourceTracker* GetResourceTracker() = 0;
   virtual VarTracker* GetVarTracker() = 0;
   virtual CallbackTracker* GetCallbackTrackerForInstance(
       PP_Instance instance) = 0;
 
   virtual base::Lock* GetProxyLock() = 0;
@@ skipping 57 matching lines @@
   static PpapiGlobals* ppapi_globals_;
 
   scoped_refptr<base::MessageLoopProxy> main_loop_proxy_;
 
   DISALLOW_COPY_AND_ASSIGN(PpapiGlobals);
 };
 
 }  // namespace ppapi
 
 #endif  // PPAPI_SHARED_IMPL_PPAPI_GLOBALS_H_