Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1185893007: fix null-pointer deref in SkComposeShader::toString() (Closed)

Created:
5 years, 6 months ago by hal.canary
Modified:
5 years, 6 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix null-pointer deref in SkComposeShader::toString() Committed: https://skia.googlesource.com/skia/+/8464a960b83e3577bfa419693b3b27dfad82c8c8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/core/SkComposeShader.cpp View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
hal.canary
PTAL
5 years, 6 months ago (2015-06-16 17:44:12 UTC) #2
robertphillips
lgtm + request https://codereview.chromium.org/1185893007/diff/1/src/core/SkComposeShader.cpp File src/core/SkComposeShader.cpp (right): https://codereview.chromium.org/1185893007/diff/1/src/core/SkComposeShader.cpp#newcode201 src/core/SkComposeShader.cpp:201: str->append("ShaderA: "); might as well add ...
5 years, 6 months ago (2015-06-16 17:46:13 UTC) #3
hal.canary
On 2015/06/16 17:46:13, robertphillips wrote: > lgtm + request > > https://codereview.chromium.org/1185893007/diff/1/src/core/SkComposeShader.cpp > File src/core/SkComposeShader.cpp ...
5 years, 6 months ago (2015-06-16 17:49:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185893007/1
5 years, 6 months ago (2015-06-16 18:47:51 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 18:53:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8464a960b83e3577bfa419693b3b27dfad82c8c8

Powered by Google App Engine
This is Rietveld 408576698