Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp

Issue 1185843010: bindings: Moves custom getters/setters to the prototype chain. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 29 matching lines...) Expand all
40 40
41 namespace blink { 41 namespace blink {
42 42
43 // Save the state value to a hidden attribute in the V8PopStateEvent, and return it, for convenience. 43 // Save the state value to a hidden attribute in the V8PopStateEvent, and return it, for convenience.
44 static v8::Local<v8::Value> cacheState(v8::Local<v8::Object> popStateEvent, v8:: Local<v8::Value> state, v8::Isolate* isolate) 44 static v8::Local<v8::Value> cacheState(v8::Local<v8::Object> popStateEvent, v8:: Local<v8::Value> state, v8::Isolate* isolate)
45 { 45 {
46 V8HiddenValue::setHiddenValue(isolate, popStateEvent, V8HiddenValue::state(i solate), state); 46 V8HiddenValue::setHiddenValue(isolate, popStateEvent, V8HiddenValue::state(i solate), state);
47 return state; 47 return state;
48 } 48 }
49 49
50 void V8PopStateEvent::stateAttributeGetterCustom(const v8::PropertyCallbackInfo< v8::Value>& info) 50 void V8PopStateEvent::stateAttributeGetterCustom(const v8::FunctionCallbackInfo< v8::Value>& info)
51 { 51 {
52 v8::Local<v8::Value> result = V8HiddenValue::getHiddenValue(info.GetIsolate( ), info.Holder(), V8HiddenValue::state(info.GetIsolate())); 52 v8::Local<v8::Value> result = V8HiddenValue::getHiddenValue(info.GetIsolate( ), info.Holder(), V8HiddenValue::state(info.GetIsolate()));
53 53
54 if (!result.IsEmpty()) { 54 if (!result.IsEmpty()) {
55 v8SetReturnValue(info, result); 55 v8SetReturnValue(info, result);
56 return; 56 return;
57 } 57 }
58 58
59 PopStateEvent* event = V8PopStateEvent::toImpl(info.Holder()); 59 PopStateEvent* event = V8PopStateEvent::toImpl(info.Holder());
60 History* history = event->history(); 60 History* history = event->history();
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 result = event->serializedState()->deserialize(info.GetIsolate()); 95 result = event->serializedState()->deserialize(info.GetIsolate());
96 V8HiddenValue::setHiddenValue(info.GetIsolate(), v8History, V8HiddenValu e::state(info.GetIsolate()), result); 96 V8HiddenValue::setHiddenValue(info.GetIsolate(), v8History, V8HiddenValu e::state(info.GetIsolate()), result);
97 } else { 97 } else {
98 result = event->serializedState()->deserialize(info.GetIsolate()); 98 result = event->serializedState()->deserialize(info.GetIsolate());
99 } 99 }
100 100
101 v8SetReturnValue(info, cacheState(info.Holder(), result, info.GetIsolate())) ; 101 v8SetReturnValue(info, cacheState(info.Holder(), result, info.GetIsolate())) ;
102 } 102 }
103 103
104 } // namespace blink 104 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/custom/V8MessageEventCustom.cpp ('k') | Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698