Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

Issue 1185843010: bindings: Moves custom getters/setters to the prototype chain. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 #include "bindings/core/v8/V8ArrayBuffer.h" 36 #include "bindings/core/v8/V8ArrayBuffer.h"
37 #include "bindings/core/v8/V8Binding.h" 37 #include "bindings/core/v8/V8Binding.h"
38 #include "bindings/core/v8/V8Blob.h" 38 #include "bindings/core/v8/V8Blob.h"
39 #include "bindings/core/v8/V8HiddenValue.h" 39 #include "bindings/core/v8/V8HiddenValue.h"
40 #include "bindings/core/v8/V8MessagePort.h" 40 #include "bindings/core/v8/V8MessagePort.h"
41 #include "bindings/core/v8/V8Window.h" 41 #include "bindings/core/v8/V8Window.h"
42 #include "core/events/MessageEvent.h" 42 #include "core/events/MessageEvent.h"
43 43
44 namespace blink { 44 namespace blink {
45 45
46 void V8MessageEvent::dataAttributeGetterCustom(const v8::PropertyCallbackInfo<v8 ::Value>& info) 46 void V8MessageEvent::dataAttributeGetterCustom(const v8::FunctionCallbackInfo<v8 ::Value>& info)
47 { 47 {
48 v8::Local<v8::Value> cachedData = V8HiddenValue::getHiddenValue(info.GetIsol ate(), info.Holder(), V8HiddenValue::data(info.GetIsolate())); 48 v8::Local<v8::Value> cachedData = V8HiddenValue::getHiddenValue(info.GetIsol ate(), info.Holder(), V8HiddenValue::data(info.GetIsolate()));
49 if (!cachedData.IsEmpty()) { 49 if (!cachedData.IsEmpty()) {
50 v8SetReturnValue(info, cachedData); 50 v8SetReturnValue(info, cachedData);
51 return; 51 return;
52 } 52 }
53 53
54 MessageEvent* event = V8MessageEvent::toImpl(info.Holder()); 54 MessageEvent* event = V8MessageEvent::toImpl(info.Holder());
55 55
56 v8::Local<v8::Value> result; 56 v8::Local<v8::Value> result;
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 if (!isUndefinedOrNull(info[portArrayIndex])) { 115 if (!isUndefinedOrNull(info[portArrayIndex])) {
116 portArray = adoptPtrWillBeNoop(new MessagePortArray); 116 portArray = adoptPtrWillBeNoop(new MessagePortArray);
117 *portArray = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort> (info[portArrayIndex], portArrayIndex + 1, info.GetIsolate(), exceptionState); 117 *portArray = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort> (info[portArrayIndex], portArrayIndex + 1, info.GetIsolate(), exceptionState);
118 if (exceptionState.throwIfNeeded()) 118 if (exceptionState.throwIfNeeded())
119 return; 119 return;
120 } 120 }
121 event->initMessageEvent(typeArg, canBubbleArg, cancelableArg, ScriptValue(Sc riptState::current(info.GetIsolate()), dataArg), originArg, lastEventIdArg, sour ceArg, portArray.release()); 121 event->initMessageEvent(typeArg, canBubbleArg, cancelableArg, ScriptValue(Sc riptState::current(info.GetIsolate()), dataArg), originArg, lastEventIdArg, sour ceArg, portArray.release());
122 } 122 }
123 123
124 } // namespace blink 124 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698