Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

Issue 1185843010: bindings: Moves custom getters/setters to the prototype chain. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 namespace blink { 44 namespace blink {
45 45
46 static v8::Local<v8::Value> cacheState(v8::Isolate* isolate, v8::Local<v8::Objec t> customEvent, v8::Local<v8::Value> detail) 46 static v8::Local<v8::Value> cacheState(v8::Isolate* isolate, v8::Local<v8::Objec t> customEvent, v8::Local<v8::Value> detail)
47 { 47 {
48 V8HiddenValue::setHiddenValue(isolate, customEvent, V8HiddenValue::detail(is olate), detail); 48 V8HiddenValue::setHiddenValue(isolate, customEvent, V8HiddenValue::detail(is olate), detail);
49 return detail; 49 return detail;
50 } 50 }
51 51
52 52
53 void V8CustomEvent::detailAttributeGetterCustom(const v8::PropertyCallbackInfo<v 8::Value>& info) 53 void V8CustomEvent::detailAttributeGetterCustom(const v8::FunctionCallbackInfo<v 8::Value>& info)
54 { 54 {
55 CustomEvent* event = V8CustomEvent::toImpl(info.Holder()); 55 CustomEvent* event = V8CustomEvent::toImpl(info.Holder());
56 56
57 v8::Local<v8::Value> result = V8HiddenValue::getHiddenValue(info.GetIsolate( ), info.Holder(), V8HiddenValue::detail(info.GetIsolate())); 57 v8::Local<v8::Value> result = V8HiddenValue::getHiddenValue(info.GetIsolate( ), info.Holder(), V8HiddenValue::detail(info.GetIsolate()));
58 58
59 if (!result.IsEmpty()) { 59 if (!result.IsEmpty()) {
60 v8SetReturnValue(info, result); 60 v8SetReturnValue(info, result);
61 return; 61 return;
62 } 62 }
63 63
(...skipping 19 matching lines...) Expand all
83 if (!v8Call(info[1]->BooleanValue(info.GetIsolate()->GetCurrentContext()), c anBubbleArg) 83 if (!v8Call(info[1]->BooleanValue(info.GetIsolate()->GetCurrentContext()), c anBubbleArg)
84 || !v8Call(info[2]->BooleanValue(info.GetIsolate()->GetCurrentContext()) , cancelableArg)) 84 || !v8Call(info[2]->BooleanValue(info.GetIsolate()->GetCurrentContext()) , cancelableArg))
85 return; 85 return;
86 v8::Local<v8::Value> detailsArg = info[3]; 86 v8::Local<v8::Value> detailsArg = info[3];
87 87
88 event->initEvent(typeArg, canBubbleArg, cancelableArg); 88 event->initEvent(typeArg, canBubbleArg, cancelableArg);
89 event->setDetail(ScriptValue(ScriptState::current(info.GetIsolate()), detail sArg)); 89 event->setDetail(ScriptValue(ScriptState::current(info.GetIsolate()), detail sArg));
90 } 90 }
91 91
92 } // namespace blink 92 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698