Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 118583003: gyps! and builds!

Created:
6 years, 12 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
CC:
chromium-reviews, craigdh+watch_chromium.org, cbentzel+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

gyps! and builds! issues: * silly linux-only binaries in: + ndk + sdk * host binaries think they're built for linux * gyp adds linux-specific linker flags (--begin-group, --end-group) (host compiler is clang on os x with current xcode versions, so some minor flag tweaks are necessary) #export ANDROID_NDK_ROOT=/Users/thakis/Downloads/android-ndk-r9b # Make sure you have sdk 19: #export ANDROID_SDK_ROOT=/Users/thakis/Documents/android-sdk-macosx # also `ln -s android-4.3 19.0.0` in $ANDROID_SDK_ROOT/build-tools` # copy over the two gyp files in third_party/..../ndk . build/android/envsetup.sh #GYP_GENERATORS=ninja-android android_gyp -Goutput_dir=out_android AR=/Users/thakis/Downloads/android-ndk-r9b/toolchains/arm-linux-androideabi-4.8/prebuilt/darwin-x86_64/bin/arm-linux-androideabi-ar \ GYP_DEFINES="OS=android enable_webrtc=0 fastbuild=1 disable_nacl=1 disable_pnacl=1 dcheck_always_on=1" \ build/gyp_chromium -Goutput_dir=out_android \ -Dandroid_ndk_root=/Users/thakis/Downloads/android-ndk-r9b \ -Dandroid_sdk_root=/Users/thakis/Documents/android-sdk-macosx BUG=277641 needs https://codereview.chromium.org/208113002

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : fixrebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Patch Set 10 : rebase #

Patch Set 11 : . #

Patch Set 12 : cc #

Patch Set 13 : build more #

Patch Set 14 : build more #

Patch Set 15 : build more (5000 files!) #

Patch Set 16 : builds! (and then: [FATAL:base_paths_android.cc(26)] Check failed: false. Unable to resolve /proc/s… #

Patch Set 17 : rebase #

Patch Set 18 : rebase #

Patch Set 19 : wat #

Patch Set 20 : . #

Patch Set 21 : . #

Patch Set 22 : rebase #

Patch Set 23 : rebase #

Patch Set 24 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -52 lines) Patch
M base/base.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +7 lines, -9 lines 0 comments Download
M build/android/envsetup.sh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -1 line 0 comments Download
M build/android/gyp/ant.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 13 chunks +35 lines, -14 lines 0 comments Download
M build/filename_rules.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +2 lines, -2 lines 0 comments Download
M build/gyp_chromium View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 3 chunks +2 lines, -2 lines 0 comments Download
M content/app/android/child_process_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libevent/libevent.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mach_override/mach_override.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/forwarder.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +23 lines, -18 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698