dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart - Issue 11858017: Nice messages on uncaught exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 11858017: Nice messages on uncaught exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments and fix a type error Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart » ('j') | dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

index d94adf17cf8403973a7dda970ff3e20fb0e385a2..5dfacf3744ee2014f2e13a5280af820659396cf2 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

@@ -390,11 +390,14 @@ $lazyInitializerLogic

$isolate[fieldName] = sentinelInProgress;

try {

result = $isolate[fieldName] = lazyValue();

- } catch (e) {

- if ($isolate[fieldName] === sentinelInProgress) {

- $isolate[fieldName] = null;

+ } finally {

+""" // Use try-finally, not try-catch/throw as it destroys the stack trace.

+"""

+ if (result === sentinelUndefined) {

+ if ($isolate[fieldName] === sentinelInProgress) {

+ $isolate[fieldName] = null;

+ }

}

- throw e;

}

} else if (result === sentinelInProgress) {

$cyclicThrow(staticName);