Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 11858007: Splits SmoothGestureController from RenderWidgetHostImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Single smooth scroll Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.h
diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h
index c980966c7fa93ca84acab2555813127d55531eb7..583e98fa78ca6ea2da86e4973f5b2d86a95a5281 100644
--- a/content/browser/renderer_host/render_widget_host_impl.h
+++ b/content/browser/renderer_host/render_widget_host_impl.h
@@ -68,7 +68,7 @@ class MockRenderWidgetHost;
class OverscrollController;
class RenderWidgetHostDelegate;
class RenderWidgetHostViewPort;
-class SmoothScrollGesture;
+class SmoothScrollGestureController;
class TouchEventQueue;
struct EditCommand;
@@ -565,8 +565,8 @@ class CONTENT_EXPORT RenderWidgetHostImpl : virtual public RenderWidgetHost,
void OnInputEventAck(WebKit::WebInputEvent::Type event_type,
InputEventAckState ack_result);
void OnBeginSmoothScroll(
- int gesture_id,
- const ViewHostMsg_BeginSmoothScroll_Params &params);
+ const ViewHostMsg_BeginSmoothScroll_Params& params,
+ bool* smooth_scroll_started);
void OnSelectRangeAck();
void OnMsgMoveCaretAck();
virtual void OnFocus();
@@ -676,9 +676,6 @@ class CONTENT_EXPORT RenderWidgetHostImpl : virtual public RenderWidgetHost,
// which may get in recursive loops).
void DelayedAutoResized();
- // Called periodically to advance the active scroll gesture after being
- // initiated by OnBeginSmoothScroll.
- void TickActiveSmoothScrollGesture();
// Our delegate, which wants to know mainly about keyboard events.
// It will remain non-NULL until DetachDelegate() is called.
@@ -865,12 +862,7 @@ class CONTENT_EXPORT RenderWidgetHostImpl : virtual public RenderWidgetHost,
base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_;
- typedef std::map<int, scoped_refptr<SmoothScrollGesture> >
- SmoothScrollGestureMap;
- SmoothScrollGestureMap active_smooth_scroll_gestures_;
- base::TimeTicks last_smooth_scroll_gestures_tick_time_;
- bool tick_active_smooth_scroll_gestures_task_posted_;
-
+ scoped_ptr<SmoothScrollGestureController> smooth_scroll_gesture_controller_;
scoped_ptr<TouchEventQueue> touch_event_queue_;
scoped_ptr<GestureEventFilter> gesture_event_filter_;
scoped_ptr<OverscrollController> overscroll_controller_;

Powered by Google App Engine
This is Rietveld 408576698