Splits SmoothGestureController from RenderWidgetHostImpl

content/common/view_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for page rendering.
 // Multiply-included message file, hence no include guard.
 
 #include "base/process.h"
 #include "base/shared_memory.h"
 #include "base/string16.h"
@@ skipping 829 matching lines @@
 // Ack goes directly from browser -> renderer. This is not used for the threaded
 // compositor path.
 IPC_MESSAGE_ROUTED0(ViewMsg_SwapBuffers_ACK)
 
 // Sends an input event to the render widget.
 IPC_MESSAGE_ROUTED2(ViewMsg_HandleInputEvent,
                     IPC::WebInputEventPointer /* event */,
                     bool /* is_keyboard_shortcut */)
 
 // Tells the render widget that a smooth scroll completed.
-IPC_MESSAGE_ROUTED1(ViewMsg_SmoothScrollCompleted,
-                    int /* gesture_id */)
+IPC_MESSAGE_ROUTED0(ViewMsg_SmoothScrollCompleted)

[rjkroege, 2013/02/21 19:26:33]

using a RenderViewHostObserver could save you needing to add this here too?

[bulach, 2013/02/22 16:55:14]

hmm.. this is just being changed, not added, but anyways.. :)
I can move this to a separate file, say "smooth_scroll_messages.h" if you
prefer?
however, as for making the |gesture controller| a RenderViewHostObserver, I'm
not quite clear if that would be worth it: my understanding is that this needs
to be hooked at RenderWidgetHostImpl, which is a parallel hierarchy to
RenderViewHost, so it wouldn't be possible to instantiate the |gesture
controller| at construction time... I mean, my understanding is that it'd be
only possible after the bottom of the diamond, |RenderViewHostImpl|, is
instantiated.

however, I may have missed some "view x host x impl" combination here, please
let me know if this is simpler than I'm seeing :)

 
 // This message notifies the renderer that the next key event is bound to one
 // or more pre-defined edit commands. If the next key event is not handled
 // by webkit, the specified edit commands shall be executed against current
 // focused frame.
 // Parameters
 // * edit_commands (see chrome/common/edit_command_types.h)
 //   Contains one or more edit commands.
 // See third_party/WebKit/Source/WebCore/editing/EditorCommand.cpp for detailed
 // definition of webkit edit commands.
@@ skipping 810 matching lines @@
                     WebKit::WebInputEvent::Type,
                     content::InputEventAckState /* ack_result */)
 
 IPC_STRUCT_BEGIN(ViewHostMsg_BeginSmoothScroll_Params)
   IPC_STRUCT_MEMBER(bool, scroll_down)
   IPC_STRUCT_MEMBER(int, pixels_to_scroll)
   IPC_STRUCT_MEMBER(int, mouse_event_x)
   IPC_STRUCT_MEMBER(int, mouse_event_y)
 IPC_STRUCT_END()
 
-IPC_MESSAGE_ROUTED2(ViewHostMsg_BeginSmoothScroll,
-                    int /* gesture_id */,
-                    ViewHostMsg_BeginSmoothScroll_Params /* params */)
+IPC_SYNC_MESSAGE_ROUTED1_1(ViewHostMsg_BeginSmoothScroll,
+                           ViewHostMsg_BeginSmoothScroll_Params /* params */,
+                           bool /* smooth_scroll_started */)
 
 IPC_MESSAGE_ROUTED0(ViewHostMsg_Focus)
 IPC_MESSAGE_ROUTED0(ViewHostMsg_Blur)
 
 // Message sent from renderer to the browser when focus changes inside the
 // webpage. The parameter says whether the newly focused element needs
 // keyboard input (true for textfields, text areas and content editable divs).
 IPC_MESSAGE_ROUTED1(ViewHostMsg_FocusedNodeChanged,
     bool /* is_editable_node */)
 
@@ skipping 705 matching lines @@
 // cached by the OS. Please see RenderMessageFilter::OnPreCacheFontCharacters
 // for details.
 IPC_SYNC_MESSAGE_CONTROL2_0(ViewHostMsg_PreCacheFontCharacters,
                             LOGFONT /* font_data */,
                             string16 /* characters */)
 #endif
 
 // Notifies the browser that the frame with the given id was detached.
 IPC_MESSAGE_ROUTED1(ViewHostMsg_FrameDetached,
                     int64 /* frame_id */)