Tools/Scripts/webkitpy/w3c/test_importer.py - Issue 1185793002: Parsing expectations for run-webkit-tests takes >20 seconds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/w3c/test_importer.py

Issue 1185793002: Parsing expectations for run-webkit-tests takes >20 seconds. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use a set and rename variable Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Tools/Scripts/webkitpy/w3c/test_importer.py

diff --git a/Tools/Scripts/webkitpy/w3c/test_importer.py b/Tools/Scripts/webkitpy/w3c/test_importer.py

index 6259613ee11a2627d4aabe9b790a70e877a0a9aa..a6f6ea71092fbfb19fff3c3a11c2cab9dcca2fcc 100644

--- a/Tools/Scripts/webkitpy/w3c/test_importer.py

+++ b/Tools/Scripts/webkitpy/w3c/test_importer.py

@@ -296,7 +296,7 @@ class TestImporter(object):

port = self.host.port_factory.get()

w3c_import_expectations_path = self.webkit_finder.path_from_webkit_base('LayoutTests', 'W3CImportExpectations')

w3c_import_expectations = self.filesystem.read_text_file(w3c_import_expectations_path)

- parser = TestExpectationParser(port, full_test_list=(), is_lint_mode=False)

+ parser = TestExpectationParser(port, all_tests=(), is_lint_mode=False)

expectation_lines = parser.parse(w3c_import_expectations_path, w3c_import_expectations)

for line in expectation_lines:

if 'SKIP' in line.expectations:

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py ('k') | no next file » | no next file with comments »