Parsing expectations for run-webkit-tests takes >20 seconds.

Parsing expectations for run-webkit-tests takes >20 seconds.

All this time is in TestExpecationsParser.parse on line 204:
if expectation_line.path in self._full_test_list:

Instead, use a dictionary so this lookup is O(1) instead of O(n).
This saves 20-25 seconds on my desktop machine.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197078

[ojan, 2015-06-12 17:45:54]

ojan@chromium.org changed reviewers:
+ dpranke@chromium.org, joelo@chromium.org

[joelo, 2015-06-12 17:52:28]

lgtm

[ojan, 2015-06-12 17:57:11]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2015-06-12 17:57:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1185793002/20001

[commit-bot: I haz the power, 2015-06-12 17:57:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 17:57:36]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[ojan, 2015-06-12 18:13:37]

dpranke: owner lgtm plz when you get a chance.

[Dirk Pranke, 2015-06-12 19:16:26]

nice! I'm surprised that we had anything like this left unoptimized.

However, maybe this should be a set() instead of a dict()? I'd expect you'd get
the same speedup and it would be a little clearer.

[Dirk Pranke, 2015-06-12 19:16:46]

lgtm

[ojan, 2015-06-13 00:48:46]

On 2015/06/12 at 19:16:26, dpranke wrote:
> nice! I'm surprised that we had anything like this left unoptimized.
> 
> However, maybe this should be a set() instead of a dict()? I'd expect you'd
get the same speedup and it would be a little clearer.

Lol. Yes. It's been a while since I've written python code. :)

I also renamed the variable to _all_tests instead of encoding the type in the
variable name. Couldn't bring myself to rename it again to _full_test_set.

[ojan, 2015-06-13 00:51:40]

The CQ bit was checked by ojan@chromium.org

[ojan, 2015-06-13 00:51:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, joelo@chromium.org
Link to the patchset: https://codereview.chromium.org/1185793002/#ps40001
(title: "use a set and rename variable")

[commit-bot: I haz the power, 2015-06-13 00:52:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1185793002/40001

[commit-bot: I haz the power, 2015-06-13 02:13:30]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197078