Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1185783002: [SP] Temporarily disable two frame navigation tests made flaky by slimming paint. (Closed)

Created:
5 years, 6 months ago by wkorman
Modified:
5 years, 6 months ago
Reviewers:
chrishtr, skobes
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SP] Temporarily disable two frame navigation tests made flaky by slimming paint. BUG=498938, 497950 TBR=jochen Committed: https://crrev.com/7d2a7dea802bc88849b705cfc6448bd5abeda3f1 Cr-Commit-Position: refs/heads/master@{#334205}

Patch Set 1 #

Patch Set 2 : Merge changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/session_history_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
wkorman
5 years, 6 months ago (2015-06-12 17:28:12 UTC) #2
skobes
lgtm
5 years, 6 months ago (2015-06-12 17:31:46 UTC) #3
chrishtr
lgtm
5 years, 6 months ago (2015-06-12 17:44:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185783002/10002
5 years, 6 months ago (2015-06-12 17:46:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/70569)
5 years, 6 months ago (2015-06-12 17:55:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185783002/10002
5 years, 6 months ago (2015-06-12 18:01:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/70581)
5 years, 6 months ago (2015-06-12 18:10:37 UTC) #14
wkorman
+jam for OWNERS.
5 years, 6 months ago (2015-06-12 18:14:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185783002/10002
5 years, 6 months ago (2015-06-12 18:26:20 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:10002)
5 years, 6 months ago (2015-06-12 18:42:09 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7d2a7dea802bc88849b705cfc6448bd5abeda3f1 Cr-Commit-Position: refs/heads/master@{#334205}
5 years, 6 months ago (2015-06-12 18:43:10 UTC) #21
chrishtr
5 years, 6 months ago (2015-06-12 21:28:20 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:10002) has been created in
https://codereview.chromium.org/1181163005/ by chrishtr@chromium.org.

The reason for reverting is: crbug.com/498938 is now fixed..

Powered by Google App Engine
This is Rietveld 408576698