chrome/browser/chromeos/chrome_browser_main_chromeos.cc - Issue 1185753008: Proposed alternative for supporting ChromeVox keyboard commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 1185753008: Proposed alternative for supporting ChromeVox keyboard commands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove ui/events/* changes. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/accessibility/spoken_feedback_event_rewriter.cc ('K') | « chrome/browser/chromeos/accessibility/spoken_feedback_event_rewriter_unittest.cc ('k') | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc

index 58e2dbdaf12608b1c21345102e299b8a9a5e59b1..7e58ffaaa9de8a118a363ab8e50c20d3516dc15d 100644

--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc

+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc

@@ -26,6 +26,7 @@

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/chromeos/accessibility/accessibility_manager.h"

#include "chrome/browser/chromeos/accessibility/magnification_manager.h"

+#include "chrome/browser/chromeos/accessibility/spoken_feedback_event_rewriter.h"

#include "chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h"

#include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h"

#include "chrome/browser/chromeos/app_mode/kiosk_mode_idle_app_name_notification.h"

@@ -653,6 +654,8 @@ void ChromeBrowserMainPartsChromeos::PostBrowserStart() {

keyboard_event_rewriters_.reset(new EventRewriterController());

keyboard_event_rewriters_->AddEventRewriter(

scoped_ptr<ui::EventRewriter>(new KeyboardDrivenEventRewriter()));

+ keyboard_event_rewriters_->AddEventRewriter(

+ scoped_ptr<ui::EventRewriter>(new SpokenFeedbackEventRewriter(nullptr)));

keyboard_event_rewriters_->AddEventRewriter(scoped_ptr<ui::EventRewriter>(

new EventRewriter(ash::Shell::GetInstance()->sticky_keys_controller())));

keyboard_event_rewriters_->Init();