Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1185753005: Return int from outlineWidth() and outlineSize() (Closed)

Created:
5 years, 6 months ago by davve
Modified:
5 years, 6 months ago
CC:
blink-reviews, dshwang, blink-reviews-style_chromium.org, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Return int from outlineWidth() and outlineSize() The underlying storage is an int and it's usually used together with plain ints. BUG=496033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/paint/ImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/ComputedStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185753005/1
5 years, 6 months ago (2015-06-15 14:32:00 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-15 15:41:18 UTC) #4
davve
And yet one more. PTAL.
5 years, 6 months ago (2015-06-15 16:10:08 UTC) #6
mstensho (USE GERRIT)
lgtm
5 years, 6 months ago (2015-06-16 07:01:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185753005/1
5 years, 6 months ago (2015-06-16 07:02:26 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 07:05:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197159

Powered by Google App Engine
This is Rietveld 408576698