Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1185733002: Remove ambiguity of SkJpegUtility name. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove ambiguity of SkJpegUtility name. We have two, one in images/, the other in codec/. As codec's the new hotness, I left it's name vanilla and suffixed the old one. BUG=skia: Committed: https://skia.googlesource.com/skia/+/93858b49a9f3bd3037d61822c095ef59199870af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -234 lines) Patch
M gyp/images.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/images/SkImageDecoder_libjpeg.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/images/SkJpegUtility.h View 1 chunk +0 lines, -65 lines 0 comments Download
D src/images/SkJpegUtility.cpp View 1 chunk +0 lines, -166 lines 0 comments Download
A + src/images/SkJpegUtility_images.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/images/SkJpegUtility_images.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein_C
5 years, 6 months ago (2015-06-12 15:10:58 UTC) #2
mtklein
(I don't think anything's broken. I just got confused.)
5 years, 6 months ago (2015-06-12 15:13:40 UTC) #4
scroggo
lgtm
5 years, 6 months ago (2015-06-12 15:27:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185733002/1
5 years, 6 months ago (2015-06-12 15:30:17 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 15:43:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/93858b49a9f3bd3037d61822c095ef59199870af

Powered by Google App Engine
This is Rietveld 408576698