Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 118573002: Revert of Moved text decoding to the parser thread (Closed)

Created:
7 years ago by oystein (OOO til 10th of July)
Modified:
7 years ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@parserthread_step25
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -965 lines) Patch
M Source/core/core.gypi View 1 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.cpp View 1 4 chunks +19 lines, -8 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 5 chunks +13 lines, -14 lines 0 comments Download
M Source/core/dom/DocumentEncodingData.h View 1 1 chunk +9 lines, -21 lines 0 comments Download
D Source/core/dom/DocumentEncodingData.cpp View 1 1 chunk +0 lines, -56 lines 0 comments Download
M Source/core/dom/DocumentParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/DocumentResource.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FontResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ScriptResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ShaderResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/fetch/TextResourceDecoder.h View 1 2 chunks +1 line, -2 lines 0 comments Download
A + Source/core/fetch/TextResourceDecoder.cpp View 1 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/fetch/XSLStyleSheetResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/HTMLBaseElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.h View 1 6 chunks +8 lines, -11 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.cpp View 1 4 chunks +0 lines, -44 lines 0 comments Download
M Source/core/html/parser/CSSPreloadScanner.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 5 chunks +14 lines, -51 lines 0 comments Download
M Source/core/html/parser/HTMLMetaCharsetParser.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLMetaCharsetParser.cpp View 1 3 chunks +89 lines, -9 lines 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.cpp View 1 2 chunks +0 lines, -90 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLTokenizer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLTokenizer.cpp View 1 2 chunks +10 lines, -11 lines 0 comments Download
M Source/core/html/parser/HTMLViewSourceParser.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/parser/TextDocumentParser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/TextDocumentParser.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
D Source/core/html/parser/TextResourceDecoder.h View 1 1 chunk +0 lines, -106 lines 0 comments Download
D Source/core/html/parser/TextResourceDecoder.cpp View 1 1 chunk +0 lines, -437 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 1 5 chunks +22 lines, -31 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/NetworkResourcesData.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentWriter.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/loader/TextResourceDecoderBuilder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerScriptLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLTProcessor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
oystein (OOO til 10th of July)
Created Revert of Moved text decoding to the parser thread
7 years ago (2013-12-18 20:03:00 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-18 20:03:04 UTC) #2
Nate Chapin
lgtm
7 years ago (2013-12-18 20:06:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oysteine@chromium.org/118573002/1
7 years ago (2013-12-18 20:06:50 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/core/page/PageSerializer.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-18 20:07:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oysteine@chromium.org/118573002/150001
7 years ago (2013-12-18 21:23:00 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-18 21:24:16 UTC) #7
Message was sent while issue was closed.
Change committed as 164116

Powered by Google App Engine
This is Rietveld 408576698