Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2527)

Unified Diff: components/omnibox/base_search_provider.h

Issue 1185723002: Prepare HistoryProvider for componentization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/base_search_provider.h
diff --git a/components/omnibox/base_search_provider.h b/components/omnibox/base_search_provider.h
index a709e8c42d09d8f42087227e9cd241832f879ddd..8d1d187eb57f782175aa59ff664b8f568898dfb1 100644
--- a/components/omnibox/base_search_provider.h
+++ b/components/omnibox/base_search_provider.h
@@ -50,7 +50,7 @@ class BaseSearchProvider : public AutocompleteProvider {
static const int kDeletionURLFetcherID;
BaseSearchProvider(TemplateURLService* template_url_service,
- scoped_ptr<AutocompleteProviderClient> client,
+ AutocompleteProviderClient* client,
AutocompleteProvider::Type type);
Peter Kasting 2015/06/16 00:03:43 Nit: For consistency with HistoryProvider, I'd ord
blundell 2015/06/16 07:21:25 Done.
// Returns whether |match| is flagged as a query that should be prefetched.
@@ -221,7 +221,7 @@ class BaseSearchProvider : public AutocompleteProvider {
virtual void RecordDeletionResult(bool success) = 0;
TemplateURLService* template_url_service_;
- scoped_ptr<AutocompleteProviderClient> client_;
+ AutocompleteProviderClient* client_;
// Whether a field trial, if any, has triggered in the most recent
// autocomplete query. This field is set to true only if the suggestion

Powered by Google App Engine
This is Rietveld 408576698