Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: components/omnibox/autocomplete_provider_client.h

Issue 1185723002: Prepare HistoryProvider for componentization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/autocomplete_provider_client.h
diff --git a/components/omnibox/autocomplete_provider_client.h b/components/omnibox/autocomplete_provider_client.h
index 0cbdc07688f1192e44e9b2dea53551d2d98e8de8..ce217f00b93cb1e4908f099736ccfc7076a51743 100644
--- a/components/omnibox/autocomplete_provider_client.h
+++ b/components/omnibox/autocomplete_provider_client.h
@@ -13,7 +13,12 @@ struct AutocompleteMatch;
class AutocompleteSchemeClassifier;
class GURL;
+namespace bookmarks {
+class BookmarkModel;
+}
+
namespace history {
+class HistoryService;
class URLDatabase;
}
@@ -44,6 +49,12 @@ class AutocompleteProviderClient {
// Returns the scheme classifier.
virtual const AutocompleteSchemeClassifier& SchemeClassifier() = 0;
+ // Returns the HistoryService.
Peter Kasting 2015/06/12 16:20:23 The order of these functions seems totally random.
blundell 2015/06/15 08:51:33 Agreed. I'll send you a separate CL for this as th
+ virtual history::HistoryService* HistoryService() = 0;
+
+ // Returns the bookmarks:BookmarkModel
+ virtual bookmarks::BookmarkModel* BookmarkModel() = 0;
+
// Given some string |text| that the user wants to use for navigation,
// determines how it should be interpreted.
virtual void Classify(

Powered by Google App Engine
This is Rietveld 408576698